Bug 165816 - Add a PerfTest targeting IDBObjectStore.get()
Summary: Add a PerfTest targeting IDBObjectStore.get()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-12-13 12:21 PST by Brady Eidson
Modified: 2016-12-13 12:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2016-12-13 12:22 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-12-13 12:21:29 PST 
Add a PerfTest targeting IDBObjectStore.get()
Comment 1 Brady Eidson 2016-12-13 12:22:14 PST 
Created attachment 297033 [details]
Patch
Comment 2 Daniel Bates 2016-12-13 12:24:27 PST 
Comment on attachment 297033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297033&action=review

> PerformanceTests/IndexedDB/objectstore-get.html:41
> +function *runIteration()

I'm surprised that star in front of runIterations does not cause a syntax error.
Comment 3 Daniel Bates 2016-12-13 12:27:09 PST 
(In reply to comment #2)
> Comment on attachment 297033 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297033&action=review
> 
> > PerformanceTests/IndexedDB/objectstore-get.html:41
> > +function *runIteration()
> 
> I'm surprised that star in front of runIterations does not cause a syntax
> error.

Disregard this remark. function* is the syntax to define a generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*>
Comment 4 WebKit Commit Bot 2016-12-13 12:42:16 PST 
Comment on attachment 297033 [details]
Patch

Clearing flags on attachment: 297033

Committed r209772: <http://trac.webkit.org/changeset/209772>
Comment 5 WebKit Commit Bot 2016-12-13 12:42:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brady Eidson 2016-12-13 12:51:04 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 297033 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=297033&action=review
> > 
> > > PerformanceTests/IndexedDB/objectstore-get.html:41
> > > +function *runIteration()
> > 
> > I'm surprised that star in front of runIterations does not cause a syntax
> > error.
> 
> Disregard this remark. function* is the syntax to define a
> generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> Statements/function*>

Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of function generators to right linear tests for it. :)
Comment 7 Brady Eidson 2016-12-13 12:51:51 PST 
(In reply to comment #6)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Comment on attachment 297033 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=297033&action=review
> > > 
> > > > PerformanceTests/IndexedDB/objectstore-get.html:41
> > > > +function *runIteration()
> > > 
> > > I'm surprised that star in front of runIterations does not cause a syntax
> > > error.
> > 
> > Disregard this remark. function* is the syntax to define a
> > generator,<https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> > Statements/function*>
> 
> Yup - Because of how asynchronous IndexedDB is, we've fallen into the
> pattern of function generators to right linear tests for it. :)

Wow. To say that again:

Yup - Because of how asynchronous IndexedDB is, we've fallen into the pattern of *using* function generators to *write* linear tests for it.