Bug 165468 - YouTube sometimes pauses when switching tabs
Summary: YouTube sometimes pauses when switching tabs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-06 08:45 PST by Jer Noble
Modified: 2016-12-06 14:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.69 KB, patch)
2016-12-06 14:05 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (10.56 KB, patch)
2016-12-06 14:24 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-12-06 08:45:48 PST 
YouTube sometimes pauses when switching tabs
Comment 1 Jer Noble 2016-12-06 14:05:22 PST 
Created attachment 296316 [details]
Patch
Comment 2 Eric Carlson 2016-12-06 14:15:18 PST 
Comment on attachment 296316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296316&action=review

> Source/WebCore/testing/Internals.cpp:2818
> +    if (restrictions | PlatformMediaSessionManager::BackgroundProcessPlaybackRestricted) {

you probably meant "restrictions &" here.

> LayoutTests/media/media-session-restrictions.html:12
> +
> +

Nit: extra blank line.
Comment 3 Jer Noble 2016-12-06 14:24:01 PST 
Created attachment 296319 [details]
Patch
Comment 4 Jer Noble 2016-12-06 14:31:38 PST 
rdar://problem/29267937
Comment 5 WebKit Commit Bot 2016-12-06 14:48:44 PST 
Comment on attachment 296319 [details]
Patch

Clearing flags on attachment: 296319

Committed r209425: <http://trac.webkit.org/changeset/209425>
Comment 6 WebKit Commit Bot 2016-12-06 14:48:48 PST 
All reviewed patches have been landed.  Closing bug.