Bug 165153 - Web Inspector: Breakpoints button enabled state is too subtle
Summary: Web Inspector: Breakpoints button enabled state is too subtle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-29 12:59 PST by Matt Baker
Modified: 2016-11-29 13:50 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2016-11-29 13:02 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] before/after (23.81 KB, image/png)
2016-11-29 13:09 PST, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-11-29 12:59:54 PST 
The color change to the breakpoint outline is hard to see. Xcode uses a filled style for the breakpoint button when enabled.
Comment 1 Matt Baker 2016-11-29 13:02:11 PST 
Created attachment 295623 [details]
Patch
Comment 2 Matt Baker 2016-11-29 13:09:53 PST 
Created attachment 295624 [details]
[Image] before/after
Comment 3 Joseph Pecoraro 2016-11-29 13:24:58 PST 
Comment on attachment 295623 [details]
Patch

r=me! Sweet!
Comment 4 WebKit Commit Bot 2016-11-29 13:50:10 PST 
Comment on attachment 295623 [details]
Patch

Clearing flags on attachment: 295623

Committed r209089: <http://trac.webkit.org/changeset/209089>
Comment 5 WebKit Commit Bot 2016-11-29 13:50:14 PST 
All reviewed patches have been landed.  Closing bug.