Bug 165016 - Fix exception scope verification failures in JSArray* files.
Summary: Fix exception scope verification failures in JSArray* files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-11-21 18:48 PST by Mark Lam
Modified: 2016-11-28 15:51 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (13.87 KB, patch)
2016-11-21 19:24 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-21 18:48:02 PST
Patch coming.
Comment 1 Mark Lam 2016-11-21 19:24:16 PST
Created attachment 295320 [details]
proposed patch.
Comment 2 Saam Barati 2016-11-28 14:21:57 PST
Comment on attachment 295320 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295320&action=review

> Source/JavaScriptCore/runtime/JSArray.cpp:265
> +        ASSERT(!scope.exception());

This isn't needed since scope.release will soon assert this.
Comment 3 Mark Lam 2016-11-28 15:45:59 PST
Comment on attachment 295320 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295320&action=review

>> Source/JavaScriptCore/runtime/JSArray.cpp:265
>> +        ASSERT(!scope.exception());
> 
> This isn't needed since scope.release will soon assert this.

I'll remove this.
Comment 4 Mark Lam 2016-11-28 15:51:20 PST
Thanks for the review.  Landed in r209036: <http://trac.webkit.org/r209036>.