Bug 164677 - Follow-up: fix the OpenSource build on Mac after r208642
Summary: Follow-up: fix the OpenSource build on Mac after r208642
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-11 23:29 PST by Wenson Hsieh
Modified: 2016-11-12 11:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2016-11-11 23:30 PST, Wenson Hsieh 		rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (1.43 KB, patch)
2016-11-12 00:11 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-11-11 23:29:26 PST 
It seems I forgot to mark a property as assign.
Comment 1 Wenson Hsieh 2016-11-11 23:30:53 PST 
Created attachment 294602 [details]
Patch
Comment 2 Ryosuke Niwa 2016-11-12 00:07:35 PST 
Comment on attachment 294602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294602&action=review

rs=me.

> Source/WebCore/ChangeLog:7
> +
> +        The playbackControlsController property should also be `assign`.
> +

Missing Reviewed by.
Comment 3 Wenson Hsieh 2016-11-12 00:11:53 PST 
Created attachment 294606 [details]
Patch for landing
Comment 4 Wenson Hsieh 2016-11-12 00:12:54 PST 
Comment on attachment 294602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294602&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Missing Reviewed by.

Fixed. Thanks!
Comment 5 WebKit Commit Bot 2016-11-12 00:47:06 PST 
Comment on attachment 294606 [details]
Patch for landing

Clearing flags on attachment: 294606

Committed r208645: <http://trac.webkit.org/changeset/208645>
Comment 6 Ryosuke Niwa 2016-11-12 00:50:41 PST 
Thanks for the build fixes!