Bug 164623 - Move update image calls to RenderElement::styleDidChange.
Summary: Move update image calls to RenderElement::styleDidChange.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-10 15:42 PST by zalan
Modified: 2016-11-10 16:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.28 KB, patch)
2016-11-10 15:44 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.29 KB, patch)
2016-11-10 15:52 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-11-10 15:42:37 PST 
There should be no dependency on them between styleWillChange and styleDidChange.
Comment 1 zalan 2016-11-10 15:44:46 PST 
Created attachment 294424 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-11-10 15:46:57 PST 
Comment on attachment 294424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294424&action=review

> Source/WebCore/ChangeLog:10
> +        Not testable.

I think it is, but you're just relying on existing tests.
Comment 3 zalan 2016-11-10 15:52:18 PST 
Created attachment 294427 [details]
Patch
Comment 4 WebKit Commit Bot 2016-11-10 16:29:59 PST 
Comment on attachment 294427 [details]
Patch

Clearing flags on attachment: 294427

Committed r208571: <http://trac.webkit.org/changeset/208571>
Comment 5 WebKit Commit Bot 2016-11-10 16:30:03 PST 
All reviewed patches have been landed.  Closing bug.