Implement new HTML interactive form validation user interface on Mac WebKit1, similarly to the one for WebKit2.
Created attachment 295775 [details] WIP Patch
Attachment 295775 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295792 [details] WIP Patch
Attachment 295792 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 295792 [details] WIP Patch Attachment 295792 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2598317 New failing tests: fast/forms/validation-message-on-listbox.html fast/forms/validation-message-on-menulist.html fast/forms/validation-message-on-radio.html fast/forms/validation-message-on-checkbox.html fast/forms/validation-message-on-range.html fast/forms/validation-message-clone.html fast/forms/validation-message-in-relative-body.html fast/forms/validation-message-appearance.html fast/forms/validation-message-on-textarea.html
Created attachment 295805 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295792 [details] WIP Patch Attachment 295792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2598360 New failing tests: fast/forms/validation-message-on-listbox.html fast/forms/validation-message-on-menulist.html fast/forms/validation-message-on-radio.html fast/forms/validation-message-on-checkbox.html fast/forms/validation-message-on-range.html fast/forms/validation-message-clone.html fast/forms/validation-message-in-relative-body.html fast/forms/validation-message-appearance.html fast/forms/validation-message-on-textarea.html
Created attachment 295806 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 295856 [details] WIP Patch
Created attachment 295857 [details] Patch
Attachment 295857 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295861 [details] Patch
Attachment 295861 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295862 [details] Patch
Attachment 295862 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295864 [details] Patch
Attachment 295864 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebValidationMessageClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WARNING: Not running on native Windows. Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
<rdar://problem/29462758>
Comment on attachment 295864 [details] Patch Patch is ready for review.
Comment on attachment 295864 [details] Patch Clearing flags on attachment: 295864 Committed r209252: <http://trac.webkit.org/changeset/209252>
All reviewed patches have been landed. Closing bug.
(In reply to comment #20) > Comment on attachment 295864 [details] > Patch > > Clearing flags on attachment: 295864 > > Committed r209252: <http://trac.webkit.org/changeset/209252> It broke the Apple Mac cmake build, see build.webkit.org for details.
the super easy buildfix landed in https://trac.webkit.org/changeset/209315
Thanks, Ossy!