WebAssembly: Fix -Wreturn-type compiler warnings

[Csaba Osztrogonác]

[1019/1043] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmFormat.cpp.o
../../Source/JavaScriptCore/wasm/WasmFormat.cpp: In function 'const char* JSC::Wasm::toString(JSC::Wasm::Type)':
../../Source/JavaScriptCore/wasm/WasmFormat.cpp:50:1: warning: control reaches end of non-void function [-Wreturn-type]
[1030/1043] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmB3IRGenerator.cpp.o
In file included from ../../Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:44:0:
../../Source/JavaScriptCore/wasm/WasmFunctionParser.h: In member function 'bool JSC::Wasm::FunctionParser<Context>::parseExpression(JSC::Wasm::OpType) [with Context = JSC::Wasm::{anonymous}::B3IRGenerator]':
../../Source/JavaScriptCore/wasm/WasmFunctionParser.h:448:1: warning: control reaches end of non-void function [-Wreturn-type]
[1033/1043] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmValidate.cpp.o
In file included from ../../Source/JavaScriptCore/wasm/WasmValidate.cpp:31:0:
../../Source/JavaScriptCore/wasm/WasmFunctionParser.h: In member function 'bool JSC::Wasm::FunctionParser<Context>::parseExpression(JSC::Wasm::OpType) [with Context = JSC::Wasm::Validate]':
../../Source/JavaScriptCore/wasm/WasmFunctionParser.h:448:1: warning: control reaches end of non-void function [-Wreturn-type]
In file included from ../../Source/JavaScriptCore/wasm/WasmValidate.cpp:369:0:
DerivedSources/JavaScriptCore/WasmValidateInlines.h: In member function 'bool JSC::Wasm::Validate::unaryOp(JSC::Wasm::UnaryOpType, JSC::Wasm::Validate::ExpressionType, JSC::Wasm::Validate::ExpressionType&)':
DerivedSources/JavaScriptCore/WasmValidateInlines.h:481:1: warning: control reaches end of non-void function [-Wreturn-type]
DerivedSources/JavaScriptCore/WasmValidateInlines.h: In member function 'bool JSC::Wasm::Validate::binaryOp(JSC::Wasm::BinaryOpType, JSC::Wasm::Validate::ExpressionType, JSC::Wasm::Validate::ExpressionType, JSC::Wasm::Validate::ExpressionType&)':
DerivedSources/JavaScriptCore/WasmValidateInlines.h:1524:1: warning: control reaches end of non-void function [-Wreturn-type]
DerivedSources/JavaScriptCore/WasmValidateInlines.h: In member function 'bool JSC::Wasm::Validate::load(JSC::Wasm::LoadOpType, JSC::Wasm::Validate::ExpressionType, JSC::Wasm::Validate::ExpressionType&, uint32_t)':
DerivedSources/JavaScriptCore/WasmValidateInlines.h:1657:1: warning: control reaches end of non-void function [-Wreturn-type]
DerivedSources/JavaScriptCore/WasmValidateInlines.h: In member function 'bool JSC::Wasm::Validate::store(JSC::Wasm::StoreOpType, JSC::Wasm::Validate::ExpressionType, JSC::Wasm::Validate::ExpressionType, uint32_t)':
DerivedSources/JavaScriptCore/WasmValidateInlines.h:1781:1: warning: control reaches end of non-void function [-Wreturn-type]

We should use RELEASE_ASSERT_NOT_REACHED() to avoid these warnings and undefined behaviour due to missing return at the end of the functions.

[Csaba Osztrogonác]

Created attachment 294060 [details]
Patch

[Keith Miller]

Comment on attachment 294060 [details]
Patch

r=me.

[Michael Catanzaro]

Ossy?

[Csaba Osztrogonác]

(In reply to comment #3)
> Ossy?

Thanks for the reminder, I completely missed this bug. I'll check and land it soon if it is still valid.

[Csaba Osztrogonác]

I haven't seen any warning now, and these files changed a lot since then.