Bug 164385 - test-webkitpy failing test_create_patch_is_full_patch unit test
Summary: test-webkitpy failing test_create_patch_is_full_patch unit test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: All All
: P2 Minor
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 16:17 PDT by Jonathan Bedard
Modified: 2016-11-09 15:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2016-11-03 16:19 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2016-11-09 11:37 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2016-11-03 16:17:19 PDT 
webkitpy.common.checkout.scm.scm_unittest.SVNTest.test_create_patch_is_full_patch is a failing test.  This failure has not been noticed because this test is one of the tests only run when --all is passed to test-webkitpy.
Comment 1 Jonathan Bedard 2016-11-03 16:19:18 PDT 
Created attachment 293822 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-09 10:26:34 PST 
Comment on attachment 293822 [details]
Patch

Rejecting attachment 293822 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 293822, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 208436 = 2d598a452aee9af91577884e076abdaf39ab4b92
r208437 = c986c412d81491faf7889eb5634b97abc0309685
r208438 = 50886cd4a7d7510fc229b7f89126f6cb0ccf8404
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2484155
Comment 3 Jonathan Bedard 2016-11-09 11:37:27 PST 
Created attachment 294257 [details]
Patch
Comment 4 WebKit Commit Bot 2016-11-09 15:30:24 PST 
Comment on attachment 294257 [details]
Patch

Clearing flags on attachment: 294257

Committed r208498: <http://trac.webkit.org/changeset/208498>
Comment 5 WebKit Commit Bot 2016-11-09 15:30:27 PST 
All reviewed patches have been landed.  Closing bug.