Bug 164236 - [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
Summary: [WK1] Candidate visibility should not update as a result of selection during ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-31 12:54 PDT by Wenson Hsieh
Modified: 2016-10-31 16:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.74 KB, patch)
2016-10-31 13:07 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-10-31 12:54:42 PDT 
For WK1, we currently set candidate list visibility to NO when performing a dictionary lookup on mousedown due to a temporary selection change. We fixed the WK2 case in https://trac.webkit.org/changeset/205983, but the WK1 case was never addressed.
Comment 1 Wenson Hsieh 2016-10-31 12:55:06 PDT 
<rdar://problem/28747712>
Comment 2 Wenson Hsieh 2016-10-31 13:07:30 PDT 
Created attachment 293456 [details]
Patch
Comment 3 WebKit Commit Bot 2016-10-31 16:22:15 PDT 
Comment on attachment 293456 [details]
Patch

Clearing flags on attachment: 293456

Committed r208191: <http://trac.webkit.org/changeset/208191>
Comment 4 WebKit Commit Bot 2016-10-31 16:22:18 PDT 
All reviewed patches have been landed.  Closing bug.