Bug 164060 - Expose RTCPeerConnection unprefixed
Summary: Expose RTCPeerConnection unprefixed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-27 05:51 PDT by youenn fablet
Modified: 2016-10-28 11:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (109.90 KB, patch)
2016-10-27 07:02 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (110.00 KB, patch)
2016-10-27 07:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (109.96 KB, patch)
2016-10-28 08:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-27 05:51:13 PDT 
It does not seem worth exposing it with a prefix since this has never shipped yet.
Comment 1 youenn fablet 2016-10-27 07:02:21 PDT 
Created attachment 293015 [details]
Patch
Comment 2 youenn fablet 2016-10-27 07:10:03 PDT 
Created attachment 293017 [details]
Patch
Comment 3 Philippe Normand 2016-10-27 08:27:11 PDT 
What do you think, Adam & Alex?
Comment 4 Alejandro G. Castro 2016-10-27 22:43:48 PDT 
Great.(In reply to comment #3)
> What do you think, Adam & Alex?

Great!
Comment 5 WebKit Commit Bot 2016-10-27 23:06:36 PDT 
Comment on attachment 293017 [details]
Patch

Rejecting attachment 293017 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 293017, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
tTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/win/TestExpectations
Hunk #1 FAILED at 3622.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/win/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2390713
Comment 6 youenn fablet 2016-10-28 08:23:31 PDT 
Created attachment 293163 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-10-28 11:12:34 PDT 
Comment on attachment 293163 [details]
Patch for landing

Clearing flags on attachment: 293163

Committed r208057: <http://trac.webkit.org/changeset/208057>
Comment 8 WebKit Commit Bot 2016-10-28 11:12:38 PDT 
All reviewed patches have been landed.  Closing bug.