Bug 163874 - Remove an inaccurate comment inside DFGClobberize.h
Summary: Remove an inaccurate comment inside DFGClobberize.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-23 12:41 PDT by Saam Barati
Modified: 2019-05-02 16:17 PDT (History)
15 users (show)

See Also:

Attachments
patch (1.81 KB, patch)
2016-10-23 13:02 PDT, Saam Barati 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.59 MB, application/zip)
2016-10-23 14:03 PDT, Build Bot 		no flags Details
patch (1.91 KB, patch)
2017-06-27 15:12 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-10-23 12:41:00 PDT 
...
Comment 1 Saam Barati 2016-10-23 13:02:05 PDT 
Created attachment 292551 [details]
patch
Comment 2 Build Bot 2016-10-23 14:03:00 PDT 
Comment on attachment 292551 [details]
patch

Attachment 292551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2352488

New failing tests:
svg/wicd/test-rightsizing-b.xhtml
Comment 3 Build Bot 2016-10-23 14:03:03 PDT 
Created attachment 292554 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Filip Pizlo 2016-10-23 14:13:59 PDT 
Comment on attachment 292551 [details]
patch

Can you replace this with a blurb that it must be sound?
Comment 5 Saam Barati 2017-06-27 15:12:44 PDT 
Created attachment 313951 [details]
patch

I forgot about this bug. Putting up new version for review again.
Comment 6 WebKit Commit Bot 2017-06-27 15:43:24 PDT 
Comment on attachment 313951 [details]
patch

Clearing flags on attachment: 313951

Committed r218848: <http://trac.webkit.org/changeset/218848>
Comment 7 WebKit Commit Bot 2017-06-27 15:43:26 PDT 
All reviewed patches have been landed.  Closing bug.