Some of the PCRE regular expression tests started failing due to my breaking the firstByte optimization. I have a fix.
Created attachment 17807 [details]
Comment on attachment 17807 [details]
This looks good.
I am not sure if this and similar code near it needs to be quite as obfuscated as it is?
+ if ((cd.needOuterBracket ? bracketIsAnchored : branchIsAnchored)(codestart))
I think it would read clearer if it was just
+ if ((cd.needOuterBracket ? bracketIsAnchored(codestart) : branchIsAnchored(codestart))
Also, I know it is partially copied, but the ... in this comment doesn't seem necessary to me.
+.... except when the .* appears inside capturing parentheses, and there is a
Committed revision 28578.