RESOLVED FIXED163537
[GTK] Switch to use API::DownloadClient instead of the C API client 
https://bugs.webkit.org/show_bug.cgi?id=163537
Summary [GTK] Switch to use API::DownloadClient instead of the C API client
Carlos Garcia Campos
Reported 2016-10-17 02:31:32 PDT
Code is simpler and we avoid all the toImpl/toAPI.
Attachments
Patch (8.17 KB, patch)
2016-10-17 02:33 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-10-17 02:33:50 PDT
Created attachment 291803 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-17 02:36:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2016-10-17 02:50:29 PDT
Comment on attachment 291803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291803&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp:107 > + auto* processPool = webkitWebContextGetProcessPool(webContext); You don't have to fix it now, but eventually this function ought to return a reference.
Carlos Garcia Campos
Comment 4 2016-10-17 03:48:07 PDT
Committed r207404: <http://trac.webkit.org/changeset/207404>
Note You need to log in before you can comment on or make changes to this bug.