Bug 163537 - [GTK] Switch to use API::DownloadClient instead of the C API client
Summary: [GTK] Switch to use API::DownloadClient instead of the C API client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-10-17 02:31 PDT by Carlos Garcia Campos
Modified: 2016-10-17 03:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (8.17 KB, patch)
2016-10-17 02:33 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-10-17 02:31:32 PDT 
Code is simpler and we avoid all the toImpl/toAPI.
Comment 1 Carlos Garcia Campos 2016-10-17 02:33:50 PDT 
Created attachment 291803 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-17 02:36:35 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2016-10-17 02:50:29 PDT 
Comment on attachment 291803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291803&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp:107
> +    auto* processPool = webkitWebContextGetProcessPool(webContext);

You don't have to fix it now, but eventually this function ought to return a reference.
Comment 4 Carlos Garcia Campos 2016-10-17 03:48:07 PDT 
Committed r207404: <http://trac.webkit.org/changeset/207404>