Bug 163522 - REGRESSION(r206883): [GTK] Subtle crypto post-message-worker tests timing out
Summary: REGRESSION(r206883): [GTK] Subtle crypto post-message-worker tests timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-16 19:45 PDT by Michael Catanzaro
Modified: 2016-10-17 14:55 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-10-16 19:45:50 PDT
The following layout tests have been timing out since r206883 "Add a dummy SubtleCrypto interface":

crypto/workers/subtle/aes-postMessage-worker.html
crypto/workers/subtle/hmac-postMessage-worker.html
crypto/workers/subtle/hrsa-postMessage-worker.html
crypto/workers/subtle/multiple-postMessage-worker.html
crypto/workers/subtle/rsa-postMessage-worker.html

Hey Jiewen, any idea what could have gone wrong?
Comment 1 Jiewen Tan 2016-10-17 10:31:25 PDT
(In reply to comment #0)
> The following layout tests have been timing out since r206883 "Add a dummy
> SubtleCrypto interface":
> 
> crypto/workers/subtle/aes-postMessage-worker.html
> crypto/workers/subtle/hmac-postMessage-worker.html
> crypto/workers/subtle/hrsa-postMessage-worker.html
> crypto/workers/subtle/multiple-postMessage-worker.html
> crypto/workers/subtle/rsa-postMessage-worker.html
> 
> Hey Jiewen, any idea what could have gone wrong?

My guess is GTK doesn't fully support the Subtle interface. Probably you just need to skip crypto/workers/subtle in GTK's test expectations. Sorry for not skipping them in my patch.
Comment 2 Michael Catanzaro 2016-10-17 13:06:56 PDT
(In reply to comment #1) 
> My guess is GTK doesn't fully support the Subtle interface. Probably you
> just need to skip crypto/workers/subtle in GTK's test expectations. Sorry
> for not skipping them in my patch.

Hm, I don't think we need to skip anything; it's only five tests that are failing, so we can just leave them with timeout expectations.
Comment 3 Jiewen Tan 2016-10-17 13:44:50 PDT
(In reply to comment #2)
> (In reply to comment #1) 
> > My guess is GTK doesn't fully support the Subtle interface. Probably you
> > just need to skip crypto/workers/subtle in GTK's test expectations. Sorry
> > for not skipping them in my patch.
> 
> Hm, I don't think we need to skip anything; it's only five tests that are
> failing, so we can just leave them with timeout expectations.

I do think you want to skip them.

LayoutTests/platform/gtk/TestExpectations:381:# crypto.subtle is not yet enabled, but digest algorithms are already implemented
LayoutTests/platform/gtk/TestExpectations:383:webkit.org/b/133122 crypto/subtle [ Skip ]
LayoutTests/platform/gtk/TestExpectations:384:webkit.org/b/133122 crypto/webkitSubtle [ Skip ]
LayoutTests/platform/gtk/TestExpectations:385:webkit.org/b/133319 crypto/webkitSubtle/sha-1.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:386:webkit.org/b/133319 crypto/webkitSubtle/sha-224.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:387:webkit.org/b/133319 crypto/webkitSubtle/sha-256.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:388:webkit.org/b/133319 crypto/webkitSubtle/sha-384.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:389:webkit.org/b/133319 crypto/webkitSubtle/sha-512.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:390:webkit.org/b/133320 crypto/webkitSubtle/hmac-check-algorithm.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:391:webkit.org/b/133320 crypto/webkitSubtle/hmac-export-key.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:392:webkit.org/b/133320 crypto/webkitSubtle/hmac-generate-key.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:393:webkit.org/b/133320 crypto/webkitSubtle/hmac-import-jwk.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:394:webkit.org/b/133320 crypto/webkitSubtle/hmac-sign-verify-empty-key.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:395:webkit.org/b/133320 crypto/webkitSubtle/hmac-sign-verify.html [ Pass ]
LayoutTests/platform/gtk/TestExpectations:2314:webkit.org/b/107194 crypto/webkitSubtle/rsa-indexeddb.html [ Skip ]
Comment 4 Michael Catanzaro 2016-10-17 14:50:18 PDT
OK, I'll skip the whole directory and mark the tests against bug #133122.

I'm slightly disappointed that your patch broke tests, but since this is an experimental feature that nobody from our port is working on, I think that's OK. It'll just have to be fixed by whoever picks it up next.
Comment 5 Jiewen Tan 2016-10-17 14:55:45 PDT
(In reply to comment #4)
> OK, I'll skip the whole directory and mark the tests against bug #133122.
> 
> I'm slightly disappointed that your patch broke tests, but since this is an
> experimental feature that nobody from our port is working on, I think that's
> OK. It'll just have to be fixed by whoever picks it up next.

Apologize for not paying enough attentions for these test cases. Please feel free to contact me if you need any help for making GTK's Subtle interface done. I will be glad to help. :)