Bug 16344 - Unnecessarily calling $QMAKE_MOC
Summary: Unnecessarily calling $QMAKE_MOC
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-12-07 12:29 PST by Rodney Dawes
Modified: 2007-12-10 05:28 PST (History)
1 user (show)

See Also:

Remove unnecessary $QMAKE_MOC usage (5.28 KB, patch)
2007-12-07 12:33 PST, Rodney Dawes
mrowe: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Dawes 2007-12-07 12:29:08 PST
We are calling $QMAKE_MOC unnecessarily when generating various files. The attached patch removes these unneeded arguments.
Comment 1 Rodney Dawes 2007-12-07 12:33:29 PST
Created attachment 17779 [details]
Remove unnecessary $QMAKE_MOC usage
Comment 2 Alp Toker 2007-12-08 01:52:09 PST
Does this affect the Qt build? If Qt needs this, I don't think there's any harm in calling it for GTK+ too. If Qt doesn't need it, let's remove it.
Comment 3 Simon Hausmann 2007-12-10 04:07:50 PST
I don't see why the use of $QMAKE_MOC is unnecessary.

The perl scripts in question call gcc -E, which is not available for example when compiling in a Windows environment without cygwin. For the Qt build that is a supported build combination, and that is why we use moc's builtin primitive preprocessor for those build scripts.