Bug 16336 - Fix wx port page leaks
Summary: Fix wx port page leaks
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-12-06 22:11 PST by Kevin Ollivier
Modified: 2007-12-07 09:25 PST (History)
0 users

See Also:

Fix for page leaks in wxWebKit (4.51 KB, patch)
2007-12-06 22:12 PST, Kevin Ollivier
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2007-12-06 22:11:17 PST
In tests, we've found m_impl->frame->page() to be NULL after detachFromParent() is called, which makes our delete m_impl->frame->page() code to be a no-op and causes the page to leak on shutdown. To fix this, we retain a pointer to the page so that we can delete it on shutdown.
Comment 1 Kevin Ollivier 2007-12-06 22:12:07 PST
Created attachment 17764 [details]
Fix for page leaks in wxWebKit
Comment 2 Darin Adler 2007-12-07 01:14:34 PST
Comment on attachment 17764 [details]
Fix for page leaks in wxWebKit

Looks fine. The delete call doesn't need the check for 0, because delete already does that.

Comment 3 Kevin Ollivier 2007-12-07 09:25:53 PST
landed in r25818