Bug 16329 - [GTK] Two small cleanups
Summary: [GTK] Two small cleanups
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2007-12-06 08:23 PST by Xan Lopez
Modified: 2007-12-10 13:09 PST (History)
0 users

See Also:

Patch (8.89 KB, patch)
2007-12-06 08:25 PST, Xan Lopez
no flags Details | Formatted Diff | Diff
Cleanup (9.33 KB, patch)
2007-12-06 11:55 PST, Xan Lopez
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2007-12-06 08:23:58 PST
Rename m_webPage to m_webView in ChromeClient and chain to parent class in WebKitWebView to activate bindings.
Comment 1 Xan Lopez 2007-12-06 08:25:12 PST
Created attachment 17749 [details]
Comment 2 Xan Lopez 2007-12-06 08:29:24 PST
+    return GTK_WIDGET_CLASS(webkit_web_view_parent_class)->key_press_event (widget, event);

Extra space, blah :)
Comment 3 Xan Lopez 2007-12-06 11:55:45 PST
Created attachment 17753 [details]
Comment 4 Alp Toker 2007-12-06 12:08:31 PST
Comment on attachment 17753 [details]

Good, apart from a whitespace tweak (not your fault, it was that way before the change) and chaining up key_release to key_press (will fix up before landing).
Comment 5 Alp Toker 2007-12-10 13:09:39 PST
Landed in r28490.