Bug 163254 - Update WheelEvent / MouseEvent to stop using legacy [ConstructorTemplate=Event]
Summary: Update WheelEvent / MouseEvent to stop using legacy [ConstructorTemplate=Event]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 16:47 PDT by Chris Dumez
Modified: 2023-02-08 07:27 PST (History)
7 users (show)

See Also:

Attachments
WIP Patch (24.85 KB, patch)
2016-10-10 17:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.53 MB, application/zip)
2016-10-10 17:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (1.21 MB, application/zip)
2016-10-10 17:52 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.81 MB, application/zip)
2016-10-10 17:55 PDT, Build Bot 		no flags Details
Patch (49.97 KB, patch)
2016-10-10 19:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (49.99 KB, patch)
2016-10-10 19:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-10 16:47:09 PDT 
Update WheelEvent / MouseEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor instead.
Comment 1 Chris Dumez 2016-10-10 17:01:08 PDT 
Created attachment 291190 [details]
WIP Patch
Comment 2 Build Bot 2016-10-10 17:49:47 PDT 
Comment on attachment 291190 [details]
WIP Patch

Attachment 291190 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2258819

New failing tests:
fast/events/constructors/wheel-event-constructor.html
fast/events/constructors/mouse-event-constructor.html
Comment 3 Build Bot 2016-10-10 17:49:50 PDT 
Created attachment 291200 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-10-10 17:52:22 PDT 
Comment on attachment 291190 [details]
WIP Patch

Attachment 291190 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2258860

New failing tests:
fast/events/constructors/wheel-event-constructor.html
fast/events/constructors/mouse-event-constructor.html
Comment 5 Build Bot 2016-10-10 17:52:25 PDT 
Created attachment 291201 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-10 17:55:18 PDT 
Comment on attachment 291190 [details]
WIP Patch

Attachment 291190 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2258822

New failing tests:
fast/events/constructors/wheel-event-constructor.html
fast/events/constructors/mouse-event-constructor.html
Comment 7 Build Bot 2016-10-10 17:55:21 PDT 
Created attachment 291202 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Chris Dumez 2016-10-10 19:17:16 PDT 
Created attachment 291208 [details]
Patch
Comment 9 Chris Dumez 2016-10-10 19:40:20 PDT 
Created attachment 291214 [details]
Patch
Comment 10 WebKit Commit Bot 2016-10-10 21:46:01 PDT 
Comment on attachment 291214 [details]
Patch

Clearing flags on attachment: 291214

Committed r207041: <http://trac.webkit.org/changeset/207041>
Comment 11 WebKit Commit Bot 2016-10-10 21:46:05 PDT 
All reviewed patches have been landed.  Closing bug.