RESOLVED FIXED163212
Support scoped style for user agent shadow trees 
https://bugs.webkit.org/show_bug.cgi?id=163212
Summary Support scoped style for user agent shadow trees
Antti Koivisto
Reported 2016-10-10 07:40:49 PDT
We now support scoped style for author shadow trees. This mechanism should be also available for internal shadow trees.
Attachments
patch (64.25 KB, patch)
2016-10-11 10:21 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (64.77 KB, patch)
2016-10-11 10:28 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-yosemite (1.96 MB, application/zip)
2016-10-11 11:46 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (9.30 MB, application/zip)
2016-10-11 12:03 PDT, Build Bot 		no flags
Details
patch (117.67 KB, patch)
2016-10-11 13:52 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (100.38 KB, patch)
2016-10-12 01:17 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (100.38 KB, patch)
2016-10-12 01:20 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-10-11 09:36:04 PDT
<rdar://problem/28715318>
Antti Koivisto
Comment 2 2016-10-11 10:21:10 PDT
Created attachment 291274 [details] patch
Antti Koivisto
Comment 3 2016-10-11 10:28:15 PDT
Created attachment 291275 [details] patch
Build Bot
Comment 4 2016-10-11 11:46:29 PDT
Comment on attachment 291275 [details] patch Attachment 291275 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2264108 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-css-background.html http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-inline-stylesheet.html http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-css-webkit-image-set.html http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-css-cursor.html
Build Bot
Comment 5 2016-10-11 11:46:32 PDT
Created attachment 291281 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-10-11 12:03:20 PDT
Comment on attachment 291275 [details] patch Attachment 291275 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2264117 New failing tests: fast/dom/HTMLMeterElement/meter-styles.html fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html fast/dom/HTMLMeterElement/meter-optimums.html fast/dom/HTMLMeterElement/meter-element.html fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html fast/dom/HTMLMeterElement/meter-appearances-capacity.html fast/dom/HTMLMeterElement/meter-boundary-values.html fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
Build Bot
Comment 7 2016-10-11 12:03:24 PDT
Created attachment 291282 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 8 2016-10-11 13:52:51 PDT
Created attachment 291293 [details] patch
Antti Koivisto
Comment 9 2016-10-12 01:17:09 PDT
Created attachment 291345 [details] patch Now without separate mode. Instead UA shadow trees switch to per-scope style resolver automatically when there is a stylesheet in the shadow tree.
Antti Koivisto
Comment 10 2016-10-12 01:20:35 PDT
Created attachment 291346 [details] patch
Andreas Kling
Comment 11 2016-10-12 12:15:41 PDT
Comment on attachment 291346 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=291346&action=review r=me > Source/WebCore/css/StyleResolver.h:252 > - unsigned treeContextOrdinal : 28; > + int treeContextOrdinal; Please get rid of the surrounding union if you do this, as it will no longer serve a purpose.
Antti Koivisto
Comment 12 2016-10-13 02:26:05 PDT
https://trac.webkit.org/changeset/207280
Note You need to log in before you can comment on or make changes to this bug.