Bug 163190 – [GTK] 2.14.0 Compile Errors: GTK 3.22.1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

Arch Linux. Compiling with -DENABLE_OPENGL=OFF results in:

[ 96%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o
/tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp: In member function ‘void WebKit::AcceleratedDrawingAreaProxy::setNativeSurfaceHandleForCompositing(uint64_t)’:
/tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp:271:129: error: ‘DispatchMessageEvenWhenWaitingForSyncReply’ is not a member of ‘IPC’
 essages::DrawingArea::SetNativeSurfaceHandleForCompositing(handle), m_webPageProxy.pageID(), IPC::DispatchMessageEvenWhenWaitingForSyncReply);
                                                                                              ^~~
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12590: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/AcceleratedDrawingAreaProxy.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1101: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [Makefile:150: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

...while compiling with -DENABLE_OPENGL=ON results in:

[ 97%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/InputMethodFilter.cpp.o
/tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp: In lambda function:
/tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:158:53: error: ‘gtk_widget_queue_draw’ was not declared in this scope
         gtk_widget_queue_draw(m_webPage.viewWidget());
                                                     ^
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:14870: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/AcceleratedBackingStoreX11.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1143: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [Makefile:150: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

What is a possoble workaround/resolution?

[Carlos Garcia Campos]

(In reply to comment #0)
> Arch Linux. Compiling with -DENABLE_OPENGL=OFF results in:
> 
> [ 96%] Building CXX object
> Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/
> WebResourceLoadStatisticsStore.cpp.o
> /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/
> AcceleratedDrawingAreaProxy.cpp: In member function ‘void
> WebKit::AcceleratedDrawingAreaProxy::
> setNativeSurfaceHandleForCompositing(uint64_t)’:
> /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/
> AcceleratedDrawingAreaProxy.cpp:271:129: error:
> ‘DispatchMessageEvenWhenWaitingForSyncReply’ is not a member of ‘IPC’
>  essages::DrawingArea::SetNativeSurfaceHandleForCompositing(handle),
> m_webPageProxy.pageID(), IPC::DispatchMessageEvenWhenWaitingForSyncReply);
>                                                                             
> ^~~
> make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12590:
> Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/AcceleratedDrawingAreaProxy.
> cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [CMakeFiles/Makefile2:1101:
> Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
> make: *** [Makefile:150: all] Error 2
> ==> ERROR: A failure occurred in build().
>     Aborting...

This was already fixed in r206806, and will be merged in 2.14 branch too.

> ...while compiling with -DENABLE_OPENGL=ON results in:
> 
> [ 97%] Building CXX object
> Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/InputMethodFilter.cpp.o
> /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/
> AcceleratedBackingStoreX11.cpp: In lambda function:
> /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/
> AcceleratedBackingStoreX11.cpp:158:53: error: ‘gtk_widget_queue_draw’ was
> not declared in this scope
>          gtk_widget_queue_draw(m_webPage.viewWidget());
>                                                      ^
> make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:14870:
> Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/
> AcceleratedBackingStoreX11.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [CMakeFiles/Makefile2:1143:
> Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
> make: *** [Makefile:150: all] Error 2
> ==> ERROR: A failure occurred in build().
>     Aborting...
> 
> What is a possoble workaround/resolution?

Here we just need to include gtk.h

[Carlos Garcia Campos]

Created attachment 291105 [details]
Patch

I guess this should fix the build.

[WebKit Commit Bot]

Comment on attachment 291105 [details]
Patch

Clearing flags on attachment: 291105

Committed r206998: <http://trac.webkit.org/changeset/206998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.