RESOLVED FIXED 163181
Refactor binding generated casted-this checks for attribute setters 
https://bugs.webkit.org/show_bug.cgi?id=163181
Summary Refactor binding generated casted-this checks for attribute setters
youenn fablet
Reported 2016-10-09 07:35:22 PDT
We should align setters and getters
Attachments
Patch (131.38 KB, patch)
2016-10-09 07:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (128.75 KB, patch)
2016-10-10 00:40 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-09 07:39:53 PDT
Created attachment 291045 [details] Patch
Darin Adler
Comment 2 2016-10-09 15:34:19 PDT
Comment on attachment 291045 [details] Patch As long as everything gets inlined enough that it still generates efficient code, this looks good.
WebKit Commit Bot
Comment 3 2016-10-10 00:36:24 PDT
Comment on attachment 291045 [details] Patch Rejecting attachment 291045 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 291045, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: offset -119 lines). Hunk #69 succeeded at 4626 (offset -119 lines). 2 out of 69 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp.rej patching file Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp patching file Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2254123
youenn fablet
Comment 4 2016-10-10 00:40:18 PDT
Created attachment 291071 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-10-10 01:16:30 PDT
Comment on attachment 291071 [details] Patch for landing Clearing flags on attachment: 291071 Committed r206989: <http://trac.webkit.org/changeset/206989>
WebKit Commit Bot
Comment 6 2016-10-10 01:16:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.