Bug 163181 - Refactor binding generated casted-this checks for attribute setters
Summary: Refactor binding generated casted-this checks for attribute setters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-09 07:35 PDT by youenn fablet
Modified: 2016-10-10 01:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (131.38 KB, patch)
2016-10-09 07:39 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (128.75 KB, patch)
2016-10-10 00:40 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-09 07:35:22 PDT
We should align setters and getters
Comment 1 youenn fablet 2016-10-09 07:39:53 PDT
Created attachment 291045 [details]
Patch
Comment 2 Darin Adler 2016-10-09 15:34:19 PDT
Comment on attachment 291045 [details]
Patch

As long as everything gets inlined enough that it still generates efficient code, this looks good.
Comment 3 WebKit Commit Bot 2016-10-10 00:36:24 PDT
Comment on attachment 291045 [details]
Patch

Rejecting attachment 291045 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 291045, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
offset -119 lines).
Hunk #69 succeeded at 4626 (offset -119 lines).
2 out of 69 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp.rej
patching file Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
patching file Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2254123
Comment 4 youenn fablet 2016-10-10 00:40:18 PDT
Created attachment 291071 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-10-10 01:16:30 PDT
Comment on attachment 291071 [details]
Patch for landing

Clearing flags on attachment: 291071

Committed r206989: <http://trac.webkit.org/changeset/206989>
Comment 6 WebKit Commit Bot 2016-10-10 01:16:35 PDT
All reviewed patches have been landed.  Closing bug.