Bug 163010 - Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download
Summary: Network Session: Allow NetworkDataTask decide what to do when override is all...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 06:41 PDT by Carlos Garcia Campos
Modified: 2016-10-07 09:35 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2016-10-06 06:43 PDT, Carlos Garcia Campos 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-10-06 06:41:29 PDT 
Current code always deletes the file before starting a download when allow override is True. In soup backend we use glib API that takes care of it and tries to ensure that the original file is not deleted if the new file creation fails for whatever reason.
Comment 1 Carlos Garcia Campos 2016-10-06 06:43:56 PDT 
Created attachment 290821 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-10-07 09:35:23 PDT 
Committed r206913: <http://trac.webkit.org/changeset/206913>