163010 – Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download

RESOLVED FIXED Bug 163010

Network Session: Allow NetworkDataTask decide what to do when override is allowed for a download

https://bugs.webkit.org/show_bug.cgi?id=163010

Summary Network Session: Allow NetworkDataTask decide what to do when override is all...

Carlos Garcia Campos

Reported 2016-10-06 06:41:29 PDT

Current code always deletes the file before starting a download when allow override is True. In soup backend we use glib API that takes care of it and tries to ensure that the original file is not deleted if the new file creation fails for whatever reason.

Attachments
Patch (4.44 KB, patch) 2016-10-06 06:43 PDT, Carlos Garcia Campos	achristensen: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2016-10-06 06:43:56 PDT

Created attachment 290821 [details] Patch

Carlos Garcia Campos

Comment 2 2016-10-07 09:35:23 PDT

Committed r206913: <http://trac.webkit.org/changeset/206913>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Local Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit2

Assignee

Nobody

Reported

2016-10-06 06:41 PDT

Modified

2016-10-07 09:35 PDT History

CC List

1 user Show

URL

Keywords

Depends on

Blocks