Bug 162973 - [WK2] 304 revalidation on the network process does not update the validated response
Summary: [WK2] 304 revalidation on the network process does not update the validated r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-05 08:57 PDT by youenn fablet
Modified: 2016-10-06 01:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.60 KB, patch)
2016-10-05 09:05 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (922.37 KB, application/zip)
2016-10-05 10:05 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2 (8.11 MB, application/zip)
2016-10-05 10:16 PDT, Build Bot
no flags Details
Patch for landing (8.90 KB, patch)
2016-10-06 00:53 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (8.90 KB, patch)
2016-10-06 00:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-05 08:57:12 PDT
As can be seen from the https://github.com/w3c/web-platform-tests/pull/3592/files
Comment 1 youenn fablet 2016-10-05 09:05:19 PDT
Created attachment 290710 [details]
Patch
Comment 2 Build Bot 2016-10-05 10:05:15 PDT
Comment on attachment 290710 [details]
Patch

Attachment 290710 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2225042

New failing tests:
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html
Comment 3 Build Bot 2016-10-05 10:05:17 PDT
Created attachment 290720 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-10-05 10:16:22 PDT
Comment on attachment 290710 [details]
Patch

Attachment 290710 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2225052

New failing tests:
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html
Comment 5 Build Bot 2016-10-05 10:16:25 PDT
Created attachment 290721 [details]
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 youenn fablet 2016-10-06 00:53:29 PDT
Created attachment 290790 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-10-06 00:54:58 PDT
Comment on attachment 290790 [details]
Patch for landing

Rejecting attachment 290790 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 290790, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2229875
Comment 8 youenn fablet 2016-10-06 00:57:16 PDT
Created attachment 290791 [details]
Patch for landing
Comment 9 youenn fablet 2016-10-06 00:58:25 PDT
Rebased the cache test and made it clear why it was needed to rebase it in the ChangeLog
Comment 10 WebKit Commit Bot 2016-10-06 01:32:31 PDT
Comment on attachment 290791 [details]
Patch for landing

Clearing flags on attachment: 290791

Committed r206855: <http://trac.webkit.org/changeset/206855>
Comment 11 WebKit Commit Bot 2016-10-06 01:32:36 PDT
All reviewed patches have been landed.  Closing bug.