Bug 162862 - Fix the USE(COORDINATED_GRAPHICS) build after r206712
Summary: Fix the USE(COORDINATED_GRAPHICS) build after r206712
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-03 03:00 PDT by Csaba Osztrogonác
Modified: 2016-10-03 03:04 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-10-03 03:00:54 PDT
https://trac.webkit.org/changeset/206712 broke the USE(COORDINATED_GRAPHICS) build - EFL and GTK:
- https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29947
- https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/73574

../../Source/WebCore/page/scrolling/ScrollingStateTree.cpp: In member function ‘WebCore::ScrollingNodeID WebCore::ScrollingStateTree::attachNode(WebCore::ScrollingNodeType, WebCore::ScrollingNodeID, WebCore::ScrollingNodeID)’:
../../Source/WebCore/page/scrolling/ScrollingStateTree.cpp:108:47: error: invalid use of incomplete type ‘class WebCore::AsyncScrollingCoordinator’
             newNodeID = m_scrollingCoordinator->uniqueScrollLayerID();
invalid use of incomplete type ‘class WebCore::AsyncScrollingCoordinator’
             newNodeID = m_scrollingCoordinator->uniqueScrollLayerID();

The problem is that AsyncScrollingCoordinator is a Mac only class guarded by ENABLE(ASYNC_SCROLLING).
m_scrollingCoordinator shouldn't be used anywhere without the same guard.

( note: I just reported the bug to let you know that the build is broken,
I don't have any plan and any time to work on the fix or help fixing. )
Comment 1 Carlos Garcia Campos 2016-10-03 03:04:14 PDT
I had just landed a fix in r206730. I'm not 100% sure the change is correct, though, but it fixes the build for sure and things seem to work fine here, let's see what the bots say.