RESOLVED FIXED Bug 162774
Templatize internal FontFeatureSettings class for variation font support 
https://bugs.webkit.org/show_bug.cgi?id=162774
Summary Templatize internal FontFeatureSettings class for variation font support
Myles C. Maxfield
Reported 2016-09-30 01:32:13 PDT
Templatize internal FontFeatureSettings class for variation font support
Attachments
Patch (33.86 KB, patch)
2016-09-30 01:35 PDT, Myles C. Maxfield 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.08 MB, application/zip)
2016-09-30 03:40 PDT, Build Bot 		no flags
Details
Patch for committing (34.45 KB, patch)
2016-09-30 12:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-09-30 01:35:22 PDT
Created attachment 290310 [details] Patch
Build Bot
Comment 2 2016-09-30 03:39:59 PDT
Comment on attachment 290310 [details] Patch Attachment 290310 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2174102 New failing tests: fast/images/pixel-crack-image-background-webkit-transform-scale.html
Build Bot
Comment 3 2016-09-30 03:40:03 PDT
Created attachment 290323 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Alex Christensen
Comment 4 2016-09-30 08:20:02 PDT
Comment on attachment 290310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290310&action=review r=me, don't break linux > Source/WebCore/platform/graphics/FontTaggedSettings.h:47 > +#define _0xFF static_cast<char>(0xFF) This should be a const char.
Myles C. Maxfield
Comment 5 2016-09-30 12:54:32 PDT
Created attachment 290367 [details] Patch for committing
Myles C. Maxfield
Comment 6 2016-09-30 14:13:47 PDT
Committed r206664: <http://trac.webkit.org/changeset/206664>
Myles C. Maxfield
Comment 7 2016-09-30 14:43:58 PDT
Committed r206676: <http://trac.webkit.org/changeset/206676>
Note You need to log in before you can comment on or make changes to this bug.