WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162770
URLParser: handle syntax violations in non-UTF-8 encoded queries
https://bugs.webkit.org/show_bug.cgi?id=162770
Summary
URLParser: handle syntax violations in non-UTF-8 encoded queries
Alex Christensen
Reported
2016-09-29 22:26:31 PDT
URLParser: handle syntax violations in non-UTF-8 encoded queries
Attachments
Patch
(14.47 KB, patch)
2016-09-29 22:32 PDT
,
Alex Christensen
thorton
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2
(1.22 MB, application/zip)
2016-09-29 23:21 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-09-29 22:32:01 PDT
Created
attachment 290295
[details]
Patch
Build Bot
Comment 2
2016-09-29 23:21:09 PDT
Comment on
attachment 290295
[details]
Patch
Attachment 290295
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2173019
New failing tests: fast/images/pixel-crack-image-background-webkit-transform-scale.html
Build Bot
Comment 3
2016-09-29 23:21:12 PDT
Created
attachment 290301
[details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Alex Christensen
Comment 4
2016-09-30 07:37:10 PDT
Comment on
attachment 290295
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=290295&action=review
mac test failure unrelated.
> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:989 > + checkURL(utf16String(u"
http://host?Ãð#Ãð
"), UTF8Encoding(), {"http", "", "", "host", 0, "/", "%C3%9F%F0%9F%98%8D", utf16String(u"Ãð"), utf16String(u"
http://host/?%C3%9F%F0%9F%98%8D#Ãð
")}, false);
Remind self to not land UTF-8 encoded test, but land actual emoji. Otherwise the test won't work.
Tim Horton
Comment 5
2016-09-30 11:38:31 PDT
Comment on
attachment 290295
[details]
Patch Make sure that the test failure isn't real (but it looks like it isn't).
Alex Christensen
Comment 6
2016-09-30 11:49:09 PDT
http://trac.webkit.org/changeset/206648
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug