WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162752
URLParser should correctly parse ports with leading 0's
https://bugs.webkit.org/show_bug.cgi?id=162752
Summary
URLParser should correctly parse ports with leading 0's
Alex Christensen
Reported
2016-09-29 14:18:45 PDT
URLParser should correctly parse ports with leading 0's
Attachments
Patch
(4.38 KB, patch)
2016-09-29 14:19 PDT
,
Alex Christensen
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-09-29 14:19:32 PDT
Created
attachment 290243
[details]
Patch
Alex Christensen
Comment 2
2016-09-29 14:23:16 PDT
http://trac.webkit.org/changeset/206614
Geoffrey Garen
Comment 3
2016-09-29 14:23:38 PDT
Comment on
attachment 290243
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=290243&action=review
> Source/WebCore/platform/URLParser.cpp:2365 > + bool seenDigit = false; > + bool seenMultipleDigits = false;
size_t digitCount Then there's no need to branch. Computers like counting things.
Alex Christensen
Comment 4
2016-09-29 14:27:48 PDT
http://trac.webkit.org/changeset/206615
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug