Bug 162752 - URLParser should correctly parse ports with leading 0's
Summary: URLParser should correctly parse ports with leading 0's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 14:18 PDT by Alex Christensen
Modified: 2016-09-29 14:27 PDT (History)
0 users

See Also:


Attachments
Patch (4.38 KB, patch)
2016-09-29 14:19 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-29 14:18:45 PDT
URLParser should correctly parse ports with leading 0's
Comment 1 Alex Christensen 2016-09-29 14:19:32 PDT
Created attachment 290243 [details]
Patch
Comment 2 Alex Christensen 2016-09-29 14:23:16 PDT
http://trac.webkit.org/changeset/206614
Comment 3 Geoffrey Garen 2016-09-29 14:23:38 PDT
Comment on attachment 290243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290243&action=review

> Source/WebCore/platform/URLParser.cpp:2365
> +    bool seenDigit = false;
> +    bool seenMultipleDigits = false;

size_t digitCount

Then there's no need to branch.

Computers like counting things.
Comment 4 Alex Christensen 2016-09-29 14:27:48 PDT
http://trac.webkit.org/changeset/206615