Bug 16244 - DRT doesn't handle platform specific pixel test results correctly
Summary: DRT doesn't handle platform specific pixel test results correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-02 04:13 PST by Nikolas Zimmermann
Modified: 2008-01-07 11:59 PST (History)
2 users (show)

See Also:


Attachments
Initial patch (4.98 KB, patch)
2008-01-07 11:48 PST, Nikolas Zimmermann
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2007-12-02 04:13:25 PST
As the topic says we have a bug with platform specific pixel test results
SVG wants cross-platform *-expected.txt results, but platform specific *-expected.png files - living in platform/<yourplatform>/svg/...

Currently on every pixel test run DRT recreates the png files in svg/W3C-SVG-1.1 instead of platform/..
It compares correctly though against the PNGs living in platform/.
Comment 1 Nikolas Zimmermann 2008-01-06 14:09:55 PST
Note: I was wrong, it does not compare correctly! It compares against the new generated pixel test results :(
Comment 2 Nikolas Zimmermann 2008-01-07 11:47:23 PST
Okay, I have a fix for this. It highlights that we're missing several layout test pixel results in trunk:

?      svg/carto.net/frameless-svg-parse-error-expected.checksum
?      svg/carto.net/frameless-svg-parse-error-expected.png
?      svg/css/getComputedStyle-basic-expected.checksum
?      svg/css/getComputedStyle-basic-expected.png
?      svg/css/glyph-orientation-rounding-test-expected.checksum
?      svg/css/glyph-orientation-rounding-test-expected.png
?      svg/custom/SVGException-expected.checksum
?      svg/custom/SVGException-expected.png
?      svg/custom/embedded-svg-disallowed-in-dashboard-expected.checksum
?      svg/custom/embedded-svg-disallowed-in-dashboard-expected.png
?      svg/custom/getBBox-js-expected.checksum
?      svg/custom/getBBox-js-expected.png
?      svg/custom/image-with-prefix-in-webarchive-expected.checksum
?      svg/custom/image-with-prefix-in-webarchive-expected.png
?      svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.checksum
?      svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.png
?      svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.checksum
?      svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.png
?      svg/custom/multiple-title-elements-expected.checksum
?      svg/custom/multiple-title-elements-expected.png
?      svg/custom/path-getTotalLength-expected.checksum
?      svg/custom/path-getTotalLength-expected.png
?      svg/custom/stroke-width-click-expected.checksum
?      svg/custom/stroke-width-click-expected.png
?      svg/custom/svg-disallowed-in-dashboard-object-expected.checksum
?      svg/custom/svg-disallowed-in-dashboard-object-expected.png
?      svg/custom/svg-features-expected.checksum
?      svg/custom/svg-features-expected.png
?      svg/custom/svgsvgelement-ctm-expected.checksum
?      svg/custom/svgsvgelement-ctm-expected.png
?      svg/custom/use-dynamic-append-expected.checksum
?      svg/dom/animated-tearoff-equality-expected.checksum
?      svg/dom/animated-tearoff-equality-expected.png
?      svg/dom/animated-tearoff-lifespan-expected.checksum
?      svg/dom/animated-tearoff-lifespan-expected.png
?      svg/dom/font-face-elements-expected.checksum
?      svg/dom/font-face-elements-expected.png
?      svg/dom/length-list-parser-expected.checksum
?      svg/dom/length-list-parser-expected.png
?      svg/dom/path-parser-expected.checksum
?      svg/dom/path-parser-expected.png
?      svg/dom/points-parser-expected.checksum
?      svg/dom/points-parser-expected.png
?      svg/dom/preserve-aspect-ratio-parser-expected.checksum
?      svg/dom/preserve-aspect-ratio-parser-expected.png
?      svg/dom/rgb-color-parser-expected.checksum
?      svg/dom/rgb-color-parser-expected.png
?      svg/dom/string-list-parser-expected.checksum
?      svg/dom/string-list-parser-expected.png
?      svg/dom/svg-element-attribute-js-null-expected.checksum
?      svg/dom/svg-element-attribute-js-null-expected.png
?      svg/dom/transform-parser-expected.checksum
?      svg/dom/transform-parser-expected.png
?      svg/hixie/dynamic/001-expected.checksum
?      svg/hixie/dynamic/001-expected.png
?      svg/webarchive/svg-cursor-subresources-expected.checksum
?      svg/webarchive/svg-cursor-subresources-expected.png
?      svg/webarchive/svg-feimage-subresources-expected.checksum
?      svg/webarchive/svg-feimage-subresources-expected.png
?      svg/webarchive/svg-script-subresouces-expected.checksum
?      svg/webarchive/svg-script-subresouces-expected.png

Comment 3 Nikolas Zimmermann 2008-01-07 11:48:38 PST
Created attachment 18316 [details]
Initial patch
Comment 4 Adam Roben (:aroben) 2008-01-07 11:57:08 PST
Comment on attachment 18316 [details]
Initial patch

r=me
Comment 5 Nikolas Zimmermann 2008-01-07 11:59:26 PST
Landed in r29235.