Bug 162376 - Remove a bunch of unnecessary includes
Summary: Remove a bunch of unnecessary includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-21 22:49 PDT by Joseph Pecoraro
Modified: 2019-05-02 16:22 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (28.02 KB, patch)
2016-09-21 22:52 PDT, Joseph Pecoraro 		mark.lam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Bots (27.81 KB, patch)
2016-09-21 22:59 PDT, Joseph Pecoraro 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.00 MB, application/zip)
2016-09-22 00:01 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (985.43 KB, application/zip)
2016-09-22 00:10 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-21 22:49:07 PDT 
Remove a bunch of unnecessary includes and forward declarations.

Found while other builds were going on in and around files I was looking at.
Comment 1 Joseph Pecoraro 2016-09-21 22:52:08 PDT 
Created attachment 289522 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-09-21 22:56:43 PDT 
Comment on attachment 289522 [details]
[PATCH] Proposed Fix

r=me if EWS bots are happy.
Comment 3 Joseph Pecoraro 2016-09-21 22:59:38 PDT 
Created attachment 289523 [details]
[PATCH] For Bots
Comment 4 Build Bot 2016-09-22 00:01:40 PDT 
Comment on attachment 289522 [details]
[PATCH] Proposed Fix

Attachment 289522 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2123481

New failing tests:
fast/images/move-image-to-new-document.html
Comment 5 Build Bot 2016-09-22 00:01:45 PDT 
Created attachment 289525 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-09-22 00:10:48 PDT 
Comment on attachment 289523 [details]
[PATCH] For Bots

Attachment 289523 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2123502

New failing tests:
fast/images/move-image-to-new-document.html
Comment 7 Build Bot 2016-09-22 00:10:51 PDT 
Created attachment 289527 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Joseph Pecoraro 2016-09-26 11:47:50 PDT 
https://trac.webkit.org/changeset/206267