Bug 162069 - Web Inspector: adopt Object.awaitEvent in LayoutTests/http/tests/inspector
Summary: Web Inspector: adopt Object.awaitEvent in LayoutTests/http/tests/inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 161634
  Show dependency treegraph
 
Reported: 2016-09-16 10:48 PDT by Devin Rousso
Modified: 2016-09-19 16:38 PDT (History)
7 users (show)

See Also:


Attachments
Patch (23.84 KB, patch)
2016-09-16 16:17 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-09-16 10:48:36 PDT
.
Comment 1 Radar WebKit Bug Importer 2016-09-16 10:49:00 PDT
<rdar://problem/28340008>
Comment 2 Devin Rousso 2016-09-16 16:17:08 PDT
Created attachment 289126 [details]
Patch
Comment 3 Brian Burg 2016-09-19 02:17:21 PDT
Comment on attachment 289126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289126&action=review

r=me

> LayoutTests/http/tests/inspector/network/resource-timing.html:22
> +                WebInspector.Resource.awaitEvent(WebInspector.Resource.Event.ResponseReceived),

We lose testing that the events come through in the right order, but I don't care too much about that really.
Comment 4 WebKit Commit Bot 2016-09-19 16:38:39 PDT
Comment on attachment 289126 [details]
Patch

Clearing flags on attachment: 289126

Committed r206130: <http://trac.webkit.org/changeset/206130>
Comment 5 WebKit Commit Bot 2016-09-19 16:38:43 PDT
All reviewed patches have been landed.  Closing bug.