Bug 162054 – [CMake] Build broken with current debian testing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

Building WTR bindings is broken now in Debian testing. The reason is that '.' is no longer included in @INC for perl, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588017 and https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-1238.

[3207/3290] Generating ../../DerivedSources/InjectedBundle/JSAccessibilityTextMarker.cpp, ../../DerivedSources/InjectedBundle/JSAccessibilityTextMarker.h
FAILED: DerivedSources/InjectedBundle/JSAccessibilityTextMarker.cpp DerivedSources/InjectedBundle/JSAccessibilityTextMarker.h 
cd /home/cgarcia/src/git/gnome/WebKit/Tools/WebKitTestRunner/InjectedBundle/Bindings && /usr/bin/perl -I/home/cgarcia/src/git/gnome/WebKit/Source/WebCore/bindings/scripts /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/bindings/scripts/generate-bindings.pl --defines " ENABLE_3D_TRANSFORMS ENABLE_ACCELERATED_2D_CANVAS ENABLE_ACCESSIBILITY ENABLE_API_TESTS ENABLE_CANVAS_PATH ENABLE_CHANNEL_MESSAGING ENABLE_CONTEXT_MENUS ENABLE_CREDENTIAL_STORAGE ENABLE_CSP_NEXT ENABLE_CSS3_TEXT ENABLE_CSS_BOX_DECORATION_BREAK ENABLE_CSS_GRID_LAYOUT ENABLE_CSS_IMAGE_ORIENTATION ENABLE_CSS_IMAGE_RESOLUTION ENABLE_CSS_REGIONS ENABLE_CSS_SELECTORS_LEVEL4 ENABLE_CSS_SHAPES ENABLE_DATABASE_PROCESS ENABLE_DETAILS_ELEMENT ENABLE_DFG_JIT ENABLE_DOM4_EVENTS_CONSTRUCTOR ENABLE_DOWNLOAD_ATTRIBUTE ENABLE_DRAG_SUPPORT ENABLE_FETCH_API ENABLE_FTL_JIT ENABLE_FTPDIR ENABLE_FULLSCREEN_API ENABLE_GEOLOCATION ENABLE_ICONDATABASE ENABLE_INDEXED_DATABASE ENABLE_INDEXED_DATABASE_IN_WORKERS ENABLE_INPUT_TYPE_COLOR ENABLE_INTL ENABLE_INTROSPECTION ENABLE_JIT ENABLE_LEGACY_VENDOR_PREFIXES ENABLE_LINK_PREFETCH ENABLE_MATHML ENABLE_MEDIA_CONTROLS_SCRIPT ENABLE_MEDIA_SOURCE ENABLE_MEMORY_SAMPLER ENABLE_METER_ELEMENT ENABLE_MHTML ENABLE_MINIBROWSER ENABLE_NAVIGATOR_HWCONCURRENCY ENABLE_NETSCAPE_PLUGIN_API ENABLE_NOTIFICATIONS ENABLE_OPENGL ENABLE_PLUGIN_PROCESS_GTK2 ENABLE_PUBLIC_SUFFIX_LIST ENABLE_READABLE_STREAM_API ENABLE_REQUEST_ANIMATION_FRAME ENABLE_RESOURCE_TIMING ENABLE_SAMPLING_PROFILER ENABLE_SMOOTH_SCROLLING ENABLE_SPELLCHECK ENABLE_SUBTLE_CRYPTO ENABLE_SVG_FONTS ENABLE_THREADED_COMPOSITOR ENABLE_TOUCH_EVENTS ENABLE_USERSELECT_ALL ENABLE_USER_MESSAGE_HANDLERS ENABLE_USER_TIMING ENABLE_VIDEO ENABLE_VIDEO_TRACK ENABLE_VIEW_MODE_CSS_MEDIA ENABLE_WAYLAND_TARGET ENABLE_WEBGL ENABLE_WEB_ANIMATIONS ENABLE_WEB_AUDIO ENABLE_WEB_SOCKETS ENABLE_WEB_TIMING ENABLE_WRITABLE_STREAM_API ENABLE_X11_TARGET ENABLE_XSLT USE_LIBHYPHEN USE_LIBNOTIFY USE_REDIRECTED_XCOMPOSITE_WINDOW" --generator TestRunner --include=/home/cgarcia/src/git/gnome/WebKit/Tools/WebKitTestRunner/InjectedBundle/Bindings --outputDir /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/DerivedSources/InjectedBundle --preprocessor "/usr/lib/icecc/bin/c++ -E -P -x c++" --idlAttributesFile /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/bindings/scripts/IDLAttributes.txt /home/cgarcia/src/git/gnome/WebKit/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl
Can't locate CodeGeneratorTestRunner.pm in @INC (you may need to install the CodeGeneratorTestRunner module) (@INC contains: /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/bindings/scripts /home/cgarcia/gnome/lib/perl5 /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.2 /usr/local/share/perl/5.22.2 /usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/bindings/scripts/CodeGenerator.pm line 168.

[Carlos Garcia Campos]

Created attachment 289048 [details]
Patch

[Carlos Garcia Campos]

Committed r206020: <http://trac.webkit.org/changeset/206020>

[Fujii Hironori]

I think 'use lib' is better.

> use FindBin;
> use lib '.', $FindBin::Bin;

For example, build-webkit do that.

https://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit?rev=204444#L41

Thanks to this, we can use build-webkit as a command.
We would need to invoke 'perl -I. build-webkit' without this 'use lib'.

[Carlos Garcia Campos]

(In reply to comment #3)
> I think 'use lib' is better.
> 
> > use FindBin;
> > use lib '.', $FindBin::Bin;
> 
> For example, build-webkit do that.
> 
> https://trac.webkit.org/browser/trunk/Tools/Scripts/build-
> webkit?rev=204444#L41
> 
> Thanks to this, we can use build-webkit as a command.
> We would need to invoke 'perl -I. build-webkit' without this 'use lib'.

I don't know perl, so feel free to change to whatever you think it's better solution :-)