WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 161964
Move --no-sample-on-timeout to config.json for each bot
https://bugs.webkit.org/show_bug.cgi?id=161964
Summary
Move --no-sample-on-timeout to config.json for each bot
Jonathan Bedard
Reported
2016-09-14 08:17:50 PDT
Rolls out the changes from
https://bugs.webkit.org/show_bug.cgi?id=161699
and moves them into config.json, allowing each bot to independently define whether or not it should sample on timeout.
Attachments
Patch
(8.62 KB, patch)
2016-09-14 08:20 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(8.76 KB, patch)
2016-09-14 17:10 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2016-09-14 08:20:22 PDT
Created
attachment 288815
[details]
Patch
Daniel Bates
Comment 2
2016-09-14 09:39:52 PDT
Comment on
attachment 288815
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=288815&action=review
> Tools/ChangeLog:8 > + Roll out changes from 205573 and move them into config.json.
It would be good to add a remark to explain that support for sample'ing a process in run-webkit-tests is only implemented for macOS and iOS Simulator at the time of writing and hence it is unnecessary to pass "--no-sample-on-timeout" to run-webkit-tests for GTK, EFL, and Windows ports.
Jonathan Bedard
Comment 3
2016-09-14 17:10:27 PDT
Created
attachment 288899
[details]
Patch
WebKit Commit Bot
Comment 4
2016-09-15 08:32:08 PDT
Comment on
attachment 288899
[details]
Patch Clearing flags on attachment: 288899 Committed
r205968
: <
http://trac.webkit.org/changeset/205968
>
WebKit Commit Bot
Comment 5
2016-09-15 08:32:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug