Bug 161931 - [CSS Parser] Enable the new sizes parser by default
Summary: [CSS Parser] Enable the new sizes parser by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46591
  Show dependency tree / graph
 
Reported: 2016-09-13 15:27 PDT by Dave Hyatt
Modified: 2016-09-22 13:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (33.62 KB, patch)
2016-09-13 15:28 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (146.84 KB, patch)
2016-09-14 08:46 PDT, Dave Hyatt 		zalan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-09-13 15:27:16 PDT 
[CSS Parser] Enable the new sizes parser by default
Comment 1 Dave Hyatt 2016-09-13 15:28:47 PDT 
Created attachment 288738 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-13 15:30:30 PDT 
Attachment 288738 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2016-09-14 08:46:05 PDT 
Created attachment 288820 [details]
Patch
Comment 4 Dave Hyatt 2016-09-14 08:57:16 PDT 
Landed in r205905.
Comment 5 Ryan Haddad 2016-09-14 09:43:46 PDT 
The tests added with this change are failing on iOS-simulator

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r205905%20(14)/results.html
Comment 6 Ryan Haddad 2016-09-14 09:58:10 PDT 
(In reply to comment #5)
> The tests added with this change are failing on iOS-simulator
> 
> https://build.webkit.org/results/
> Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r205905%20(14)/
> results.html

I went ahead and rebaselined the the tests for ios-simulator in http://trac.webkit.org/projects/webkit/changeset/205911

Please let me know / revert the change if this is incorrect.