Bug 161877 – [Cocoa] Unify font's ascent, descent, and x-height between macOS and iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Unify font's ascent, descent, and x-height between macOS and iOS

[Myles C. Maxfield]

Created attachment 288624 [details]
Patch

[Myles C. Maxfield]

Created attachment 288633 [details]
Patch

[Myles C. Maxfield]

Created attachment 288635 [details]
Patch

[Myles C. Maxfield]

Created attachment 288645 [details]
WIP

[Myles C. Maxfield]

Created attachment 288658 [details]
Patch

[Build Bot]

Comment on attachment 288658 [details]
Patch

Attachment 288658 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2063120

New failing tests:
imported/blink/svg/text/obb-paintserver.html
fast/text/emoji.html
svg/W3C-SVG-1.1-SE/text-intro-05-t.svg

[Build Bot]

Created attachment 288660 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Created attachment 288661 [details]
Patch

[Myles C. Maxfield]

Created attachment 288662 [details]
Patch

[Myles C. Maxfield]

Created attachment 288663 [details]
Patch

[Build Bot]

Comment on attachment 288663 [details]
Patch

Attachment 288663 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2063461

New failing tests:
editing/selection/vertical-rl-rtl-extend-line-forward-p.html
tables/mozilla/bugs/bug55527.html
editing/selection/vertical-rl-rtl-extend-line-backward-br.html
editing/selection/vertical-rl-rtl-extend-line-forward-br.html
editing/selection/vertical-rl-rtl-extend-line-backward-p.html
svg/text/text-hkern-on-vertical-text.svg
svg/custom/glyph-transformation-with-hkern.svg
fast/text/whitespace/pre-wrap-spaces-after-newline.html
svg/custom/repaint-shadow.svg
svg/text/text-vkern-on-horizontal-text.svg
svg/W3C-SVG-1.1-SE/coords-units-03-b.svg

[Build Bot]

Created attachment 288673 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Myles C. Maxfield]

Created attachment 288675 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 288675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288675&action=review

> LayoutTests/ChangeLog:8
> +        Updating expected results.

Are any of the iOS results now identical to the Mac results and could be removed?

Do we also need to have different iOS 9 results?

[Myles C. Maxfield]

Comment on attachment 288675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288675&action=review

>> LayoutTests/ChangeLog:8
>> +        Updating expected results.
> 
> Are any of the iOS results now identical to the Mac results and could be removed?
> 
> Do we also need to have different iOS 9 results?

Unfortunately not. There are still other things in the text system which differentiates the two platforms. This patch moves them closer together, but not all the way together.

No need for iOS 9-specific results. The results for this stuff is the same on both OSes.

[Simon Fraser (smfr)]

Comment on attachment 288675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288675&action=review

> LayoutTests/imported/blink/svg/text/obb-paintserver-expected.html:24
> +  <rect y="299" width="100%" height="1" fill="black"/>
> +  <rect y="399" width="100%" height="1" fill="black"/>

Why these changes?

> LayoutTests/imported/blink/svg/text/obb-paintserver.html:24
> +  <rect y="299" width="100%" height="1" fill="black"/>
> +  <rect y="399" width="100%" height="1" fill="black"/>

Ditto

[Myles C. Maxfield]

(In reply to comment #16)
> Comment on attachment 288675 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288675&action=review
> 
> > LayoutTests/imported/blink/svg/text/obb-paintserver-expected.html:24
> > +  <rect y="299" width="100%" height="1" fill="black"/>
> > +  <rect y="399" width="100%" height="1" fill="black"/>
> 
> Why these changes?
> 
> > LayoutTests/imported/blink/svg/text/obb-paintserver.html:24
> > +  <rect y="299" width="100%" height="1" fill="black"/>
> > +  <rect y="399" width="100%" height="1" fill="black"/>
> 
> Ditto

Because the advances changed slightly, the contents got pushed out slightly from the text, thereby revealing 1px fringes around the text from our text drawing code. These divs are 1 pixel tall and cover the fringes.

[Myles C. Maxfield]

(In reply to comment #17)
> (In reply to comment #16)
> > Comment on attachment 288675 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=288675&action=review
> > 
> > > LayoutTests/imported/blink/svg/text/obb-paintserver-expected.html:24
> > > +  <rect y="299" width="100%" height="1" fill="black"/>
> > > +  <rect y="399" width="100%" height="1" fill="black"/>
> > 
> > Why these changes?
> > 
> > > LayoutTests/imported/blink/svg/text/obb-paintserver.html:24
> > > +  <rect y="299" width="100%" height="1" fill="black"/>
> > > +  <rect y="399" width="100%" height="1" fill="black"/>
> > 
> > Ditto
> 
> Because the advances changed slightly, the contents got pushed out slightly
> from the text, thereby revealing 1px fringes around the text from our text
> drawing code. These divs are 1 pixel tall and cover the fringes.

s/advances changed/ascent and descent changed/

[Myles C. Maxfield]

Committed r205883: <http://trac.webkit.org/changeset/205883>