Bug 161781 - URLParser: Handle \ in paths of special URLs according to spec
Summary: URLParser: Handle \ in paths of special URLs according to spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-08 18:29 PDT by Alex Christensen
Modified: 2016-09-08 18:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.72 KB, patch)
2016-09-08 18:30 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-08 18:29:38 PDT 
URLParser: Handle \ in paths of special URLs according to spec
Comment 1 Alex Christensen 2016-09-08 18:30:18 PDT 
Created attachment 288373 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-08 18:31:37 PDT 
Attachment 288373 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:259:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:259:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:402:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:402:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:403:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:403:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-09-08 18:34:30 PDT 
http://trac.webkit.org/changeset/205684