Bug 161558 - ProxyObject's structure should not have ObjectPrototype as its prototype and it should not have special behavior for intercepting "__proto__"
Summary: ProxyObject's structure should not have ObjectPrototype as its prototype and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks: 161455
  Show dependency treegraph
 
Reported: 2016-09-02 16:53 PDT by Saam Barati
Modified: 2016-09-06 19:50 PDT (History)
14 users (show)

See Also:


Attachments
WIP (18.37 KB, patch)
2016-09-02 17:51 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (18.35 KB, patch)
2016-09-06 17:40 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-09-02 16:53:24 PDT
This will lead to cycles in the getDirectPrototype() chain.
Comment 1 Saam Barati 2016-09-02 17:51:28 PDT
Created attachment 287840 [details]
WIP
Comment 2 Saam Barati 2016-09-02 17:52:04 PDT
Comment on attachment 287840 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=287840&action=review

> JSTests/stress/proxy-dont-infinite-loop.js:18
> +        +err;

I'm not getting an error here. Don't know why. I need to investigate. It's also a very weird err, and can't be accessed in any way, so I have no idea what it is.
Comment 3 Saam Barati 2016-09-06 17:40:55 PDT
Created attachment 288073 [details]
patch
Comment 4 WebKit Commit Bot 2016-09-06 19:50:34 PDT
Comment on attachment 288073 [details]
patch

Clearing flags on attachment: 288073

Committed r205535: <http://trac.webkit.org/changeset/205535>
Comment 5 WebKit Commit Bot 2016-09-06 19:50:38 PDT
All reviewed patches have been landed.  Closing bug.