Bug 161529 - [GTK] Fix compiler warning in MiniBrowser
Summary: [GTK] Fix compiler warning in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-02 00:44 PDT by Tomas Popela
Modified: 2016-09-02 01:56 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.92 KB, patch)
2016-09-02 00:48 PDT, Tomas Popela 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2016-09-02 00:44:22 PDT 
[5989/6114] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserTab.c.o
../../Tools/MiniBrowser/gtk/BrowserTab.c: In function ‘decidePermissionRequest’:
../../Tools/MiniBrowser/gtk/BrowserTab.c:228:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
[5991/6114] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserWindow.c.o
../../Tools/MiniBrowser/gtk/BrowserWindow.c: In function ‘browserWindowConstructed’:
../../Tools/MiniBrowser/gtk/BrowserWindow.c:955:20: warning: unused variable ‘window’ [-Wunused-variable]
     BrowserWindow *window = BROWSER_WINDOW(gObject);
                    ^~~~~~
Comment 1 Tomas Popela 2016-09-02 00:48:38 PDT 
Created attachment 287748 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2016-09-02 01:56:18 PDT 
Comment on attachment 287748 [details]
Proposed patch

Clearing flags on attachment: 287748

Committed r205343: <http://trac.webkit.org/changeset/205343>
Comment 3 WebKit Commit Bot 2016-09-02 01:56:22 PDT 
All reviewed patches have been landed.  Closing bug.