Bug 161285 – Race between creating/deleting a database in test

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Summary:
Occasional race between deleting a database and requesting database names seen in layout tests:

    inspector/indexeddb/deleteDatabaseNamesWithSpace.html

There shouldn't be any race between deleteDatabase and requestDatabaseNames.

[Joseph Pecoraro]

Okay, I think I found the real problem. The original test (which was not flakey) had a slight ordering difference because it was awkwardly using console.log as a signal. The new test doesn't wait for the same single so the order of operations can be slightly different!

The problem appears to be createDatabase might not have created the database before we call deleteDatabase. I'll write a better patch here. It might have to touch all of these inspector indexeddb tests, but at least this one for sure.

[Joseph Pecoraro]

Created attachment 287196 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Ran all inspector/indexeddb --iterations=2000 and:

    All 10000 tests ran as expected.

So yay!

[Darin Adler]

Comment on attachment 287196 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287196&action=review

> LayoutTests/ChangeLog:16
> +        Send a single when the database creation is completed.

signal/single

[WebKit Commit Bot]

Comment on attachment 287196 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287196

Committed r205086: <http://trac.webkit.org/changeset/205086>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.