Bug 161221 - Fix WebInspectorUI in internal Windows build
Summary: Fix WebInspectorUI in internal Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-25 18:03 PDT by Alex Christensen
Modified: 2016-08-30 12:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2016-08-25 18:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.65 KB, patch)
2016-08-25 18:43 PDT, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-25 18:03:06 PDT 
Fix WebInspectorUI in internal Windows build
Comment 1 Alex Christensen 2016-08-25 18:04:24 PDT 
Created attachment 287054 [details]
Patch
Comment 2 Alex Christensen 2016-08-25 18:43:49 PDT 
Created attachment 287057 [details]
Patch
Comment 3 BJ Burg 2016-08-26 12:51:00 PDT 
Comment on attachment 287057 [details]
Patch

Looks like this needs rebasing.
Comment 4 Alex Christensen 2016-08-26 13:18:35 PDT 
The patch applies fine, works, and only affects Windows.  Please review even though it claims to not apply.
Comment 5 Joseph Pecoraro 2016-08-26 15:39:20 PDT 
<rdar://problem/28019023>
Comment 6 Joseph Pecoraro 2016-08-26 15:40:13 PDT 
Comment on attachment 287057 [details]
Patch

r=me, but you may want to get Brent or another Windows expert to give it a nod.
Comment 7 Brent Fulgham 2016-08-26 16:06:32 PDT 
(In reply to comment #6)
> Comment on attachment 287057 [details]
> Patch
> 
> r=me, but you may want to get Brent or another Windows expert to give it a
> nod.

He showed it to me in person. r=me as well!
Comment 8 Joseph Pecoraro 2016-08-30 11:52:38 PDT 
Has this landed?
Comment 9 Alex Christensen 2016-08-30 12:01:42 PDT 
http://trac.webkit.org/changeset/205192