RESOLVED FIXED 161221
Fix WebInspectorUI in internal Windows build 
https://bugs.webkit.org/show_bug.cgi?id=161221
Summary Fix WebInspectorUI in internal Windows build
Alex Christensen
Reported 2016-08-25 18:03:06 PDT
Fix WebInspectorUI in internal Windows build
Attachments
Patch (4.65 KB, patch)
2016-08-25 18:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.65 KB, patch)
2016-08-25 18:43 PDT, Alex Christensen 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-08-25 18:04:24 PDT
Created attachment 287054 [details] Patch
Alex Christensen
Comment 2 2016-08-25 18:43:49 PDT
Created attachment 287057 [details] Patch
Blaze Burg
Comment 3 2016-08-26 12:51:00 PDT
Comment on attachment 287057 [details] Patch Looks like this needs rebasing.
Alex Christensen
Comment 4 2016-08-26 13:18:35 PDT
The patch applies fine, works, and only affects Windows. Please review even though it claims to not apply.
Joseph Pecoraro
Comment 5 2016-08-26 15:39:20 PDT
<rdar://problem/28019023>
Joseph Pecoraro
Comment 6 2016-08-26 15:40:13 PDT
Comment on attachment 287057 [details] Patch r=me, but you may want to get Brent or another Windows expert to give it a nod.
Brent Fulgham
Comment 7 2016-08-26 16:06:32 PDT
(In reply to comment #6) > Comment on attachment 287057 [details] > Patch > > r=me, but you may want to get Brent or another Windows expert to give it a > nod. He showed it to me in person. r=me as well!
Joseph Pecoraro
Comment 8 2016-08-30 11:52:38 PDT
Has this landed?
Alex Christensen
Comment 9 2016-08-30 12:01:42 PDT
http://trac.webkit.org/changeset/205192
Note You need to log in before you can comment on or make changes to this bug.