Bug 161020 - [GTK] Unreviewed GTK build fix since r204665 and 204668
Summary: [GTK] Unreviewed GTK build fix since r204665 and 204668
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-19 16:56 PDT by Javier Fernandez
Modified: 2016-08-20 02:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2016-08-19 16:59 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Fix build (3.37 KB, patch)
2016-08-19 18:10 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (21.04 KB, application/octet-stream)
2016-08-19 18:18 PDT, Javier Fernandez 		no flags Details
Patch (21.04 KB, patch)
2016-08-19 18:19 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (21.07 KB, patch)
2016-08-19 18:46 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (32.40 KB, patch)
2016-08-19 18:51 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (35.86 KB, patch)
2016-08-19 18:53 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (47.07 KB, patch)
2016-08-19 19:38 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (46.05 KB, patch)
2016-08-20 01:59 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (46.01 KB, patch)
2016-08-20 02:10 PDT, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2016-08-19 16:56:42 PDT 
[GTK] GTK] Unreviewed GTK build fix since r204665
Comment 1 Javier Fernandez 2016-08-19 16:59:23 PDT 
Created attachment 286498 [details]
Patch
Comment 2 Javier Fernandez 2016-08-19 18:10:53 PDT 
Created attachment 286507 [details]
Fix build
Comment 3 Javier Fernandez 2016-08-19 18:18:51 PDT 
Created attachment 286508 [details]
Patch
Comment 4 Javier Fernandez 2016-08-19 18:19:40 PDT 
Created attachment 286509 [details]
Patch
Comment 5 Javier Fernandez 2016-08-19 18:46:13 PDT 
Created attachment 286514 [details]
Patch
Comment 6 Javier Fernandez 2016-08-19 18:51:19 PDT 
Created attachment 286515 [details]
Patch
Comment 7 Javier Fernandez 2016-08-19 18:53:42 PDT 
Created attachment 286516 [details]
Patch
Comment 8 Javier Fernandez 2016-08-19 19:38:54 PDT 
Created attachment 286518 [details]
Patch
Comment 9 WebKit Commit Bot 2016-08-20 01:35:29 PDT 
Comment on attachment 286518 [details]
Patch

Rejecting attachment 286518 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 286518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
file Source/WebKit2/Shared/WebBatteryStatus.h
patching file Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp
patching file Source/WebKit2/Shared/gtk/ArgumentCodersGtk.h
patching file Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp
patching file Source/WebKit2/UIProcess/LegacySessionStateCodingNone.cpp
patching file Source/WebKit2/UIProcess/WebBatteryManagerProxy.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1906604
Comment 10 Javier Fernandez 2016-08-20 01:59:25 PDT 
Created attachment 286538 [details]
Patch
Comment 11 WebKit Commit Bot 2016-08-20 02:01:29 PDT 
Comment on attachment 286538 [details]
Patch

Rejecting attachment 286538 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 286538, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1906765
Comment 12 Javier Fernandez 2016-08-20 02:10:19 PDT 
Created attachment 286539 [details]
Patch
Comment 13 WebKit Commit Bot 2016-08-20 02:40:21 PDT 
Comment on attachment 286539 [details]
Patch

Clearing flags on attachment: 286539

Committed r204678: <http://trac.webkit.org/changeset/204678>
Comment 14 WebKit Commit Bot 2016-08-20 02:40:27 PDT 
All reviewed patches have been landed.  Closing bug.