Bug 160937 - [EFL] Fix test_ewk2_view after r203612
Summary: [EFL] Fix test_ewk2_view after r203612
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 00:20 PDT by Hunseop Jeong
Modified: 2016-08-17 04:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2016-08-17 00:25 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2016-08-17 00:20:42 PDT 
https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29337/steps/API%20tests/logs/stdio

../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:133: Failure
Value of: alertCallbackData.expectedMessage
  Actual: "undefined"
Expected: message
Which is: ""
[  FAILED  ] EWK2ViewTest.ewk_view_run_javascript_alert (257 ms)
[ RUN      ] EWK2ViewTest.ewk_view_run_javascript_confirm

../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:139: Failure
Value of: confirmCallbackData.expectedMessage
  Actual: "undefined"
Expected: message
Which is: ""
[  FAILED  ] EWK2ViewTest.ewk_view_run_javascript_confirm (126 ms)
[ RUN      ] EWK2ViewTest.ewk_view_run_javascript_prompt

../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:146: Failure
Value of: promptCallbackData.expectedMessage
  Actual: "undefined"
Expected: message
Which is: ""
[  FAILED  ] EWK2ViewTest.ewk_view_run_javascript_prompt (134 ms)
[ RUN      ] EWK2ViewTest.ewk_view_create_window
Comment 1 Hunseop Jeong 2016-08-17 00:25:13 PDT 
Created attachment 286287 [details]
Patch
Comment 2 Gyuyoung Kim 2016-08-17 03:50:57 PDT 
Comment on attachment 286287 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2016-08-17 04:14:23 PDT 
Comment on attachment 286287 [details]
Patch

Clearing flags on attachment: 286287

Committed r204557: <http://trac.webkit.org/changeset/204557>
Comment 4 WebKit Commit Bot 2016-08-17 04:14:26 PDT 
All reviewed patches have been landed.  Closing bug.