WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160908
Add WTF::ScopeExit
https://bugs.webkit.org/show_bug.cgi?id=160908
Summary
Add WTF::ScopeExit
Anders Carlsson
Reported
2016-08-16 13:38:27 PDT
Add WTF::ScopeExit
Attachments
Patch
(32.31 KB, patch)
2016-08-16 13:40 PDT
,
Anders Carlsson
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2016-08-16 13:40:19 PDT
Created
attachment 286200
[details]
Patch
Csaba Osztrogonác
Comment 2
2016-08-16 14:35:22 PDT
(In reply to
comment #1
)
> Created
attachment 286200
[details]
> Patch
Please remove unrelated xcodeproj changes.
Csaba Osztrogonác
Comment 3
2016-08-16 14:41:12 PDT
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Created
attachment 286200
[details]
> > Patch > > Please remove unrelated xcodeproj changes.
And don't ignore my review similar to
https://bugs.webkit.org/show_bug.cgi?id=160879
Geoffrey Garen
Comment 4
2016-08-16 15:10:31 PDT
Comment on
attachment 286200
[details]
Patch r=me I want this!
Anders Carlsson
Comment 5
2016-08-16 15:33:01 PDT
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Created
attachment 286200
[details]
> > Patch > > Please remove unrelated xcodeproj changes.
They were not unrelated. I sorted the Xcode project as I was adding the new files.
Anders Carlsson
Comment 6
2016-08-16 15:34:26 PDT
Committed
r204529
: <
http://trac.webkit.org/changeset/204529
>
Csaba Osztrogonác
Comment 7
2016-08-16 15:41:21 PDT
(In reply to
comment #5
)
> (In reply to
comment #2
) > > (In reply to
comment #1
) > > > Created
attachment 286200
[details]
> > > Patch > > > > Please remove unrelated xcodeproj changes. > > They were not unrelated. I sorted the Xcode project as I was adding the new > files.
They were unrelated to the goal of the bug. We don't add random style fixes to any file when we touch it, only for the the touched lines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug