Bug 160908 - Add WTF::ScopeExit
Summary: Add WTF::ScopeExit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-16 13:38 PDT by Anders Carlsson
Modified: 2016-08-16 15:41 PDT (History)
1 user (show)

See Also:

Attachments
Patch (32.31 KB, patch)
2016-08-16 13:40 PDT, Anders Carlsson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-16 13:38:27 PDT 
Add WTF::ScopeExit
Comment 1 Anders Carlsson 2016-08-16 13:40:19 PDT 
Created attachment 286200 [details]
Patch
Comment 2 Csaba Osztrogonác 2016-08-16 14:35:22 PDT 
(In reply to comment #1)
> Created attachment 286200 [details]
> Patch

Please remove unrelated xcodeproj changes.
Comment 3 Csaba Osztrogonác 2016-08-16 14:41:12 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 286200 [details]
> > Patch
> 
> Please remove unrelated xcodeproj changes.

And don't ignore my review similar to https://bugs.webkit.org/show_bug.cgi?id=160879
Comment 4 Geoffrey Garen 2016-08-16 15:10:31 PDT 
Comment on attachment 286200 [details]
Patch

r=me

I want this!
Comment 5 Anders Carlsson 2016-08-16 15:33:01 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 286200 [details]
> > Patch
> 
> Please remove unrelated xcodeproj changes.

They were not unrelated. I sorted the Xcode project as I was adding the new files.
Comment 6 Anders Carlsson 2016-08-16 15:34:26 PDT 
Committed r204529: <http://trac.webkit.org/changeset/204529>
Comment 7 Csaba Osztrogonác 2016-08-16 15:41:21 PDT 
(In reply to comment #5)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Created attachment 286200 [details]
> > > Patch
> > 
> > Please remove unrelated xcodeproj changes.
> 
> They were not unrelated. I sorted the Xcode project as I was adding the new
> files.

They were unrelated to the goal of the bug. We don't add random style
fixes to any file when we touch it, only for the the touched lines.