Bug 160683 - Load stylesheets in link elements inside a connected shadow tree
Summary: Load stylesheets in link elements inside a connected shadow tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 162744 164397
Blocks: 148695 164445
  Show dependency treegraph
 
Reported: 2016-08-08 21:22 PDT by Eric
Modified: 2016-11-04 18:52 PDT (History)
9 users (show)

See Also:


Attachments
Adds the support (31.25 KB, patch)
2016-11-02 00:50 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (29.56 KB, patch)
2016-11-04 13:02 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-yosemite (788.99 KB, application/zip)
2016-11-04 13:49 PDT, Build Bot
no flags Details
Patch for landing (27.80 KB, patch)
2016-11-04 14:00 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (27.57 KB, patch)
2016-11-04 14:00 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric 2016-08-08 21:22:05 PDT
Blink now supports stylesheets in shadow roots:
https://chromium.googlesource.com/chromium/src/+/f0cecf3ac0c7adf7a7c78eeb02cc75d380a9ce4d

Would be good to support this in webkit asap so both implementations are the same. Our developers
have asked for this for a long time, so I'm stoked that this is finally part of the spec!

Repro: http://jsbin.com/vexocusili/edit?html,output
Comment 1 Ryosuke Niwa 2016-10-04 22:07:58 PDT
We need to fix the bug 162744 first.
Comment 2 Radar WebKit Bug Importer 2016-11-01 01:01:23 PDT
<rdar://problem/29040652>
Comment 3 Ryosuke Niwa 2016-11-02 00:50:07 PDT
Created attachment 293648 [details]
Adds the support
Comment 4 Antti Koivisto 2016-11-02 13:43:55 PDT
r=me
Comment 5 WebKit Commit Bot 2016-11-02 14:37:56 PDT
Comment on attachment 293648 [details]
Adds the support

Clearing flags on attachment: 293648

Committed r208302: <http://trac.webkit.org/changeset/208302>
Comment 6 WebKit Commit Bot 2016-11-02 14:38:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Ryan Haddad 2016-11-03 16:21:02 PDT
Reverted r208302 for reason:

This change causes LayoutTest crashes under GuardMalloc.

Committed r208356: <http://trac.webkit.org/changeset/208356>
Comment 8 Ryosuke Niwa 2016-11-04 13:01:13 PDT
https://trac.webkit.org/changeset/208378 should have fixed the crash.
Comment 9 Ryosuke Niwa 2016-11-04 13:02:15 PDT
Created attachment 293915 [details]
Patch for landing
Comment 10 Build Bot 2016-11-04 13:49:34 PDT
Comment on attachment 293915 [details]
Patch for landing

Attachment 293915 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2463228

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2016-11-04 13:49:38 PDT
Created attachment 293923 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Ryosuke Niwa 2016-11-04 14:00:05 PDT
Created attachment 293924 [details]
Patch for landing
Comment 13 Ryosuke Niwa 2016-11-04 14:00:52 PDT
Created attachment 293925 [details]
Patch for landing
Comment 14 Ryosuke Niwa 2016-11-04 14:01:11 PDT
Comment on attachment 293925 [details]
Patch for landing

Wait for EWS
Comment 15 WebKit Commit Bot 2016-11-04 15:56:37 PDT
Comment on attachment 293925 [details]
Patch for landing

Clearing flags on attachment: 293925

Committed r208403: <http://trac.webkit.org/changeset/208403>
Comment 16 WebKit Commit Bot 2016-11-04 15:56:43 PDT
All reviewed patches have been landed.  Closing bug.