Bug 16061 - no-svg build broken after r27278
Summary: no-svg build broken after r27278
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL: http://trac.webkit.org/projects/webki...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-20 00:03 PST by David Kilzer (:ddkilzer)
Modified: 2007-11-20 06:52 PST (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.27 KB, patch)
2007-11-20 00:18 PST, David Kilzer (:ddkilzer) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2007-11-20 00:03:05 PST 
I broke the no-svg build after r27278 because neither DOMHTMLEmbedElementPrivate.h nor DOMHTMLObjectElementPrivate.h are created when SVG is disabled.

I'm not sure how to best fix this.  At first glance, either both header files always need to be generated (even with empty categories), or else Xcode needs to conditionalize them.  (Or I just need to remove them from Xcode.)  Note that they also need to be conditionalized in WebKit/MigrateHeaders.make.

It's sad that this wasn't noticed (probably because the no-svg buildbot is always red--Bug 12402 was filed to address that).
Comment 1 David Kilzer (:ddkilzer) 2007-11-20 00:18:30 PST 
Created attachment 17412 [details]
Patch v1

Possible solution (always generate these two files so that they exist on the no-svg build).
Comment 2 Eric Seidel (no email) 2007-11-20 05:44:23 PST 
Comment on attachment 17412 [details]
Patch v1

I think this hack is fine if you add a comment explaining what you're doing in CodeGeneratorObjC.pm.
Comment 3 David Kilzer (:ddkilzer) 2007-11-20 06:50:49 PST 
(In reply to comment #2)
> (From update of attachment 17412 [details] [edit])
> I think this hack is fine if you add a comment explaining what you're doing in
> CodeGeneratorObjC.pm.

Thanks, Eric!  I changed the code to be the comment.

Committed r27923

http://trac.webkit.org/projects/webkit/changeset/27923
Comment 4 David Kilzer (:ddkilzer) 2007-11-20 06:52:59 PST 
And fixed a typo:

Committed r27924