Bug 160574 - Syncing script's configuration duplicates a lot of boilerplate
Summary: Syncing script's configuration duplicates a lot of boilerplate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-04 16:12 PDT by Ryosuke Niwa
Modified: 2016-08-04 16:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (13.95 KB, patch)
2016-08-04 16:22 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-08-04 16:12:14 PDT
We've reduced the amount of duplication significantly in https://bugs.webkit.org/show_bug.cgi?id=152196
but we're still creating a new entry for each test, platform pair.

Avoid doing that by accepting an array of platforms and types (tests) in each configuration entry.
Comment 1 Ryosuke Niwa 2016-08-04 16:22:04 PDT
Created attachment 285375 [details]
Patch
Comment 2 Chris Dumez 2016-08-04 16:24:48 PDT
Comment on attachment 285375 [details]
Patch

rs=me
Comment 3 Ryosuke Niwa 2016-08-04 16:25:34 PDT
Committed r204151: <http://trac.webkit.org/changeset/204151>