Bug 160421 - Minor RenderBox cleanup.
Summary: Minor RenderBox cleanup.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-01 12:55 PDT by zalan
Modified: 2021-04-30 09:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.00 KB, patch)
2016-08-01 13:01 PDT, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-08-01 12:55:16 PDT 
m_inlineBoxWrapper related.
Comment 1 zalan 2016-08-01 13:01:16 PDT 
Created attachment 285034 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-08-01 13:21:18 PDT 
Comment on attachment 285034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285034&action=review

> Source/WebCore/rendering/RenderBox.cpp:113
> +bool hadOverflowClip = false;

static?

> Source/WebCore/rendering/RenderBox.h:-726
> -private:
> -    // The width/height of the contents + borders + padding.  The x/y location is relative to our container (which is not always our parent).
> -    LayoutRect m_frameRect;
> -

This could have been here to optimize padding. Use dump-class-layout to look at the before and after layout.
Comment 3 Rob Buis 2021-04-30 09:44:12 PDT 
Some of this code already landed but some is still unchanged. May be good to revisit this and either land the rest or close this, to get rid of the r+ in the queue.