RESOLVED FIXED 160269
Parameter to named property getter should be mandatory 
https://bugs.webkit.org/show_bug.cgi?id=160269
Summary Parameter to named property getter should be mandatory
Chris Dumez
Reported 2016-07-27 14:30:53 PDT
Parameter to named property getter should be mandatory: - https://heycam.github.io/webidl/#idl-named-properties
Attachments
Patch (12.82 KB, patch)
2016-07-27 14:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-27 14:33:43 PDT
Created attachment 284730 [details] Patch
Ryosuke Niwa
Comment 2 2016-07-27 14:39:17 PDT
Comment on attachment 284730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284730&action=review > Source/WebCore/ChangeLog:14 > + * bindings/scripts/test/TestOverrideBuiltins.idl: Why are you changing the bindings test?
Chris Dumez
Comment 3 2016-07-27 14:40:31 PDT
(In reply to comment #2) > Comment on attachment 284730 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284730&action=review > > > Source/WebCore/ChangeLog:14 > > + * bindings/scripts/test/TestOverrideBuiltins.idl: > > Why are you changing the bindings test? Because it does not test something very useful. Named property getter should have a mandatory parameter.
WebKit Commit Bot
Comment 4 2016-07-27 14:53:02 PDT
Comment on attachment 284730 [details] Patch Clearing flags on attachment: 284730 Committed r203797: <http://trac.webkit.org/changeset/203797>
WebKit Commit Bot
Comment 5 2016-07-27 14:53:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.