Bug 160269 - Parameter to named property getter should be mandatory
Summary: Parameter to named property getter should be mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-27 14:30 PDT by Chris Dumez
Modified: 2016-07-27 14:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (12.82 KB, patch)
2016-07-27 14:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-27 14:30:53 PDT
Parameter to named property getter should be mandatory:
- https://heycam.github.io/webidl/#idl-named-properties
Comment 1 Chris Dumez 2016-07-27 14:33:43 PDT
Created attachment 284730 [details]
Patch
Comment 2 Ryosuke Niwa 2016-07-27 14:39:17 PDT
Comment on attachment 284730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284730&action=review

> Source/WebCore/ChangeLog:14
> +        * bindings/scripts/test/TestOverrideBuiltins.idl:

Why are you changing the bindings test?
Comment 3 Chris Dumez 2016-07-27 14:40:31 PDT
(In reply to comment #2)
> Comment on attachment 284730 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284730&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        * bindings/scripts/test/TestOverrideBuiltins.idl:
> 
> Why are you changing the bindings test?

Because it does not test something very useful. Named property getter should have a mandatory parameter.
Comment 4 WebKit Commit Bot 2016-07-27 14:53:02 PDT
Comment on attachment 284730 [details]
Patch

Clearing flags on attachment: 284730

Committed r203797: <http://trac.webkit.org/changeset/203797>
Comment 5 WebKit Commit Bot 2016-07-27 14:53:07 PDT
All reviewed patches have been landed.  Closing bug.