Bug 159790 - It should be a syntax error to have a 'use strict' directive inside a function that has a non-simple parameter list
Summary: It should be a syntax error to have a 'use strict' directive inside a functio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-14 15:32 PDT by Saam Barati
Modified: 2016-07-14 19:12 PDT (History)
12 users (show)

See Also:

Attachments
patch (17.12 KB, patch)
2016-07-14 15:44 PDT, Saam Barati 		ggaren: review+
Details | Formatted Diff | Diff
patch for landing (28.27 KB, patch)
2016-07-14 16:38 PDT, Saam Barati 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (28.27 KB, patch)
2016-07-14 18:42 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-07-14 15:32:36 PDT 
...
Comment 1 Saam Barati 2016-07-14 15:33:34 PDT 
<rdar://problem/27171636>
Comment 2 Saam Barati 2016-07-14 15:44:25 PDT 
Created attachment 283696 [details]
patch
Comment 3 Geoffrey Garen 2016-07-14 15:44:59 PDT 
Comment on attachment 283696 [details]
patch

r=me
Comment 4 Saam Barati 2016-07-14 16:38:54 PDT 
Created attachment 283708 [details]
patch for landing
Comment 5 WebKit Commit Bot 2016-07-14 18:24:57 PDT 
Comment on attachment 283708 [details]
patch for landing

Rejecting attachment 283708 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 283708, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1682964
Comment 6 Saam Barati 2016-07-14 18:42:59 PDT 
Created attachment 283730 [details]
patch for landing
Comment 7 WebKit Commit Bot 2016-07-14 19:12:31 PDT 
Comment on attachment 283730 [details]
patch for landing

Clearing flags on attachment: 283730

Committed r203263: <http://trac.webkit.org/changeset/203263>
Comment 8 WebKit Commit Bot 2016-07-14 19:12:35 PDT 
All reviewed patches have been landed.  Closing bug.