Bug 159454 - [Win] Add null pointer check in gesture handling.
Summary: [Win] Add null pointer check in gesture handling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-06 00:23 PDT by Per Arne Vollan
Modified: 2016-07-06 10:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2016-07-06 00:26 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-07-06 00:23:35 PDT
When handling gestures in WebVew, we should make sure we have a valid scrollable layer.
Comment 1 Per Arne Vollan 2016-07-06 00:26:10 PDT
Created attachment 282856 [details]
Patch
Comment 2 Per Arne Vollan 2016-07-06 00:30:33 PDT
<rdar://problem/27075268>
Comment 3 Brent Fulgham 2016-07-06 08:17:42 PDT
Comment on attachment 282856 [details]
Patch

Was there a test case that illustrated this problem? We should try to add a layout test for this. Otherwise, it looks good! r=me.
Comment 4 Per Arne Vollan 2016-07-06 10:09:54 PDT
(In reply to comment #3)
> Comment on attachment 282856 [details]
> Patch
> 
> Was there a test case that illustrated this problem? We should try to add a
> layout test for this. Otherwise, it looks good! r=me.

There is no test case for this problem. I think it would involve creating a function in the Windows event sender which sends WM_GESTURE messages to the WebView. I can look into that :)

Thanks for reviewing!
Comment 5 Per Arne Vollan 2016-07-06 10:12:57 PDT
Committed r202861: <https://trac.webkit.org/changeset/202861>