WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159454
[Win] Add null pointer check in gesture handling.
https://bugs.webkit.org/show_bug.cgi?id=159454
Summary
[Win] Add null pointer check in gesture handling.
Per Arne Vollan
Reported
2016-07-06 00:23:35 PDT
When handling gestures in WebVew, we should make sure we have a valid scrollable layer.
Attachments
Patch
(2.01 KB, patch)
2016-07-06 00:26 PDT
,
Per Arne Vollan
bfulgham
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2016-07-06 00:26:10 PDT
Created
attachment 282856
[details]
Patch
Per Arne Vollan
Comment 2
2016-07-06 00:30:33 PDT
<
rdar://problem/27075268
>
Brent Fulgham
Comment 3
2016-07-06 08:17:42 PDT
Comment on
attachment 282856
[details]
Patch Was there a test case that illustrated this problem? We should try to add a layout test for this. Otherwise, it looks good! r=me.
Per Arne Vollan
Comment 4
2016-07-06 10:09:54 PDT
(In reply to
comment #3
)
> Comment on
attachment 282856
[details]
> Patch > > Was there a test case that illustrated this problem? We should try to add a > layout test for this. Otherwise, it looks good! r=me.
There is no test case for this problem. I think it would involve creating a function in the Windows event sender which sends WM_GESTURE messages to the WebView. I can look into that :) Thanks for reviewing!
Per Arne Vollan
Comment 5
2016-07-06 10:12:57 PDT
Committed
r202861
: <
https://trac.webkit.org/changeset/202861
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug